Brion VIBBER has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/347026 )
Change subject: Fix seek on resolution switching for ogv.js playback
......................................................................
Fix seek on resolution switching for ogv.js playback
Was previously seeking before creating the new player,
which reset the play head to 0 seconds when switching
resolutions. Now works in right order, and reuses the
player instead of creating a new one.
Change-Id: I004d3e012e68bb4b689c39415cf4f1455b5cd029
---
M MwEmbedModules/EmbedPlayer/resources/mw.EmbedPlayerOgvJs.js
1 file changed, 7 insertions(+), 6 deletions(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/TimedMediaHandler
refs/changes/26/347026/1
diff --git a/MwEmbedModules/EmbedPlayer/resources/mw.EmbedPlayerOgvJs.js
b/MwEmbedModules/EmbedPlayer/resources/mw.EmbedPlayerOgvJs.js
index b510bb5..7cd9420 100644
--- a/MwEmbedModules/EmbedPlayer/resources/mw.EmbedPlayerOgvJs.js
+++ b/MwEmbedModules/EmbedPlayer/resources/mw.EmbedPlayerOgvJs.js
@@ -178,14 +178,15 @@
var _this = this;
var src = source.getSrc();
var vid = this.getPlayerElement();
- if ( typeof vid.stop !== 'undefined' ) {
- vid.stop();
+
+ vid.src = source.src;
+ if ( switchCallback ) {
+ switchCallback();
}
- switchCallback();
-
- // Currently have to tear down the player and make a new one
- this.embedPlayerHTML( doneCallback );
+ if ( doneCallback ) {
+ doneCallback();
+ }
},
/**
--
To view, visit https://gerrit.wikimedia.org/r/347026
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I004d3e012e68bb4b689c39415cf4f1455b5cd029
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/TimedMediaHandler
Gerrit-Branch: master
Gerrit-Owner: Brion VIBBER <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
