Sophivorus has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/347208 )
Change subject: Fix useve param by removing unused get params
......................................................................
Fix useve param by removing unused get params
Also, cleaner URLs
Bug T147048
Change-Id: I84b3da54a4cfb54891090a171acff565c618ff9c
---
M InputBox.classes.php
1 file changed, 18 insertions(+), 6 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/InputBox
refs/changes/08/347208/1
diff --git a/InputBox.classes.php b/InputBox.classes.php
index b03ccd4..ccb1bb7 100644
--- a/InputBox.classes.php
+++ b/InputBox.classes.php
@@ -390,15 +390,27 @@
$htmlOut .= Xml::openElement( 'form', $createBoxParams );
$editArgs = $this->getEditActionArgs();
$htmlOut .= Html::hidden( $editArgs['name'], $editArgs['value']
);
- $htmlOut .= Html::hidden( 'preload', $this->mPreload );
+ if ( $this->mPreload ) {
+ $htmlOut .= Html::hidden( 'preload', $this->mPreload );
+ }
foreach ( $this->mPreloadparams as $preloadparams ) {
$htmlOut .= Html::hidden( 'preloadparams[]',
$preloadparams );
}
- $htmlOut .= Html::hidden( 'editintro', $this->mEditIntro );
- $htmlOut .= Html::hidden( 'summary', $this->mSummary );
- $htmlOut .= Html::hidden( 'nosummary', $this->mNosummary );
- $htmlOut .= Html::hidden( 'prefix', $this->mPrefix );
- $htmlOut .= Html::hidden( 'minor', $this->mMinor );
+ if ( $this->mEditIntro ) {
+ $htmlOut .= Html::hidden( 'editintro',
$this->mEditIntro );
+ }
+ if ( $this->mSummary ) {
+ $htmlOut .= Html::hidden( 'summary', $this->mSummary );
+ }
+ if ( $this->mNosummary ) {
+ $htmlOut .= Html::hidden( 'nosummary',
$this->mNosummary );
+ }
+ if ( $this->mPrefix ) {
+ $htmlOut .= Html::hidden( 'prefix', $this->mPrefix );
+ }
+ if ( $this->mMinor ) {
+ $htmlOut .= Html::hidden( 'minor', $this->mMinor );
+ }
if ( $this->mType == 'comment' ) {
$htmlOut .= Html::hidden( 'section', 'new' );
}
--
To view, visit https://gerrit.wikimedia.org/r/347208
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I84b3da54a4cfb54891090a171acff565c618ff9c
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/InputBox
Gerrit-Branch: master
Gerrit-Owner: Sophivorus <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
