Bsitu has uploaded a new change for review.
https://gerrit.wikimedia.org/r/51617
Change subject: (bug 45591) Fix inconsistent function return type
......................................................................
(bug 45591) Fix inconsistent function return type
Change-Id: Iccc4acb2bb809d0f957d73d6e8a4da3033839c1e
---
M controller/NotificationController.php
1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Echo
refs/changes/17/51617/1
diff --git a/controller/NotificationController.php
b/controller/NotificationController.php
index 973c859..9acea57 100644
--- a/controller/NotificationController.php
+++ b/controller/NotificationController.php
@@ -132,10 +132,10 @@
return;
}
- // Check if the event object still has an enabled type. The
check is necessary because an extension could
- // get turned off and we may still have un-processed event type
in the queue
+ // Check if the event object has valid event type. Events with
invalid
+ // event types left in the job queue should not be processed
if ( !$event->isEnabledEvent() ) {
- return false;
+ return;
}
if ( $event->getType() == 'welcome' ) { // Welcome events
should only be sent to the new user, no need for subscriptions.
--
To view, visit https://gerrit.wikimedia.org/r/51617
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iccc4acb2bb809d0f957d73d6e8a4da3033839c1e
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Echo
Gerrit-Branch: master
Gerrit-Owner: Bsitu <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
