Jonas Kress (WMDE) has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/347346 )
Change subject: Fixes for (embed) editing with Query Helper
......................................................................
Fixes for (embed) editing with Query Helper
-debounce query execution
-update query URL
-empty result
-no underscore in created SPARQL variables
Change-Id: I98faedb2706894020dbc817b7214c39873f8a519
---
M embed.html
M wikibase/queryService/ui/visualEditor/VisualEditor.js
2 files changed, 7 insertions(+), 4 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/wikidata/query/gui
refs/changes/46/347346/1
diff --git a/embed.html b/embed.html
index 7245077..edf90ba 100644
--- a/embed.html
+++ b/embed.html
@@ -210,9 +210,9 @@
function renderEdit( query, callback ) {
var ve = new
wikibase.queryService.ui.visualEditor.VisualEditor();
- ve.setChangeListener( function( v ) {
+ ve.setChangeListener( _.debounce( function( v )
{
callback( v.getQuery() );
- } );
+ }, 1500 ) );
var $editor = $( '<div>' );
ve.setQuery( query );
@@ -227,9 +227,13 @@
}
function renderQuery( query ) {
+ $( '.edit-link' ).attr( 'href',
'https://query.wikidata.org/' + window.location.hash )
+ window.location.hash = '#' +
encodeURIComponent( query )
+
var browser = getResultBrowser( query );
var api = new
wikibase.queryService.api.Sparql();
$( '#query-result' ).hide();
+ $( '#query-result' ).empty();
$( '#progress' ).show();
api.query( query ).done( function() {
try {
@@ -247,7 +251,6 @@
} );
}
- $( '.edit-link' ).attr( 'href',
'https://query.wikidata.org/' + window.location.hash )
var query = decodeURIComponent(
window.location.hash.substr( 1 ) );
renderQuery( query );
renderEdit( query, renderQuery );
diff --git a/wikibase/queryService/ui/visualEditor/VisualEditor.js
b/wikibase/queryService/ui/visualEditor/VisualEditor.js
index b65fb6e..3327c31 100644
--- a/wikibase/queryService/ui/visualEditor/VisualEditor.js
+++ b/wikibase/queryService/ui/visualEditor/VisualEditor.js
@@ -424,7 +424,7 @@
if ( !subject ) {
return;
}
- var variable2 = '?_' + name.replace( /( |[^a-z0-9])/gi,
'_' );// FIXME technical debt
+ var variable2 = '?' + name.replace( /( |[^a-z0-9])/gi,
'_' );// FIXME technical debt
var triple = self._query.addTriple( subject, prop,
variable2, true );
self._query.addVariable( variable2 );
--
To view, visit https://gerrit.wikimedia.org/r/347346
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I98faedb2706894020dbc817b7214c39873f8a519
Gerrit-PatchSet: 1
Gerrit-Project: wikidata/query/gui
Gerrit-Branch: master
Gerrit-Owner: Jonas Kress (WMDE) <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
