GWicke has submitted this change and it was merged.
Change subject: Add changes string to XML reports
......................................................................
Add changes string to XML reports
There was a change (gerrit change I590e21ab771290380315adeb2c8e28438e90939f)
that added the changes in JSON.stringified format to the test title. Jenkins
really needs that to tell selser tests apart, so now our JUnit output has it
also.
Change-Id: I0249772a14c6447b9d8ff1e88efec760ea817a0f
---
M js/tests/parserTests.js
1 file changed, 6 insertions(+), 9 deletions(-)
Approvals:
GWicke: Verified; Looks good to me, approved
diff --git a/js/tests/parserTests.js b/js/tests/parserTests.js
index 878fd8e..7fdaa83 100644
--- a/js/tests/parserTests.js
+++ b/js/tests/parserTests.js
@@ -1422,20 +1422,17 @@
/**
* Print the result of a test in XML.
*
- * @arg title {string} The title of the test
- * @arg time {object} The times for the test--an object with 'start'
and 'end' in milliseconds since epoch.
- * @arg comments {Array} Any comments associated with the test
- * @arg iopts {object|null} Any options for the test (not options
passed into the process)
- * @arg expected {object} Expected output for this test. Contains 'raw'
and 'normal' as above.
- * @arg actual {object} Actual output from the parser. Contains 'raw'
and 'normal', the output in different formats
- * @arg options {object} Options for the test runner. Usually just a
copy of argv.
- * @arg mode {string} The mode we're in (wt2wt, wt2html, html2wt, or
html2html)
+ * @inheritdoc ParserTests#printResult
*/
- reportResultXML = function ( title, time, comments, iopts, expected,
actual, options, mode ) {
+ reportResultXML = function ( title, time, comments, iopts, expected,
actual, options, mode, item ) {
var timeTotal, testcaseEle;
var quick = booleanOption( options.quick );
var quiet = booleanOption( options.quiet );
+ if ( mode === 'selser' ) {
+ title += ' ' + JSON.stringify( item.changes );
+ }
+
testcaseEle = '<testcase name="' + Util.encodeXml( title ) + '"
';
testcaseEle += 'assertions="1" ';
--
To view, visit https://gerrit.wikimedia.org/r/51618
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0249772a14c6447b9d8ff1e88efec760ea817a0f
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Parsoid
Gerrit-Branch: master
Gerrit-Owner: MarkTraceur <[email protected]>
Gerrit-Reviewer: GWicke <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
