Jonas Kress (WMDE) has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/347349 )
Change subject: Prepare `SiteLinkSetsChanger.tests` for jQuery version migration ...................................................................... Prepare `SiteLinkSetsChanger.tests` for jQuery version migration See https://gerrit.wikimedia.org/r/#/c/322812/ Bug: T158941 Change-Id: Ia5b9a1649bb25e702f4206a43ce56d4f9dadfea6 --- M view/tests/qunit/wikibase/entityChangers/SiteLinkSetsChanger.tests.js 1 file changed, 5 insertions(+), 2 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase refs/changes/49/347349/1 diff --git a/view/tests/qunit/wikibase/entityChangers/SiteLinkSetsChanger.tests.js b/view/tests/qunit/wikibase/entityChangers/SiteLinkSetsChanger.tests.js index 607c7b5..a2bae88 100644 --- a/view/tests/qunit/wikibase/entityChangers/SiteLinkSetsChanger.tests.js +++ b/view/tests/qunit/wikibase/entityChangers/SiteLinkSetsChanger.tests.js @@ -35,13 +35,16 @@ { getSitelinksRevision: function() { return 0; } }, new wb.datamodel.Item( 'Q1' ) ); + var done = assert.async(); siteLinksChanger.save( new wb.datamodel.SiteLinkSet( [ new wb.datamodel.SiteLink( 'siteId', 'pageName' ) ] ), new wb.datamodel.SiteLinkSet() - ); + ).done( function( savedFingerprint ) { + assert.ok( api.setSitelink.calledOnce ); + done(); + } ) - assert.ok( api.setSitelink.calledOnce ); } ); QUnit.test( 'save correctly handles API response', function( assert ) { -- To view, visit https://gerrit.wikimedia.org/r/347349 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ia5b9a1649bb25e702f4206a43ce56d4f9dadfea6 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Jonas Kress (WMDE) <[email protected]> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
