Esanders has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/347358 )
Change subject: Trigger diff element resize on dialog resize
......................................................................
Trigger diff element resize on dialog resize
Depends-On: I82a67a4309bf76db5407ea38c26c47d14c01e921
Change-Id: I912a99edca25ff576e2872723f91afe54e36a170
---
M modules/ve-mw/ui/dialogs/ve.ui.MWSaveDialog.js
1 file changed, 30 insertions(+), 5 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor
refs/changes/58/347358/1
diff --git a/modules/ve-mw/ui/dialogs/ve.ui.MWSaveDialog.js
b/modules/ve-mw/ui/dialogs/ve.ui.MWSaveDialog.js
index 79ff36c..c2a669d 100644
--- a/modules/ve-mw/ui/dialogs/ve.ui.MWSaveDialog.js
+++ b/modules/ve-mw/ui/dialogs/ve.ui.MWSaveDialog.js
@@ -205,7 +205,6 @@
*/
ve.ui.MWSaveDialog.prototype.clearVisualDiff = function () {
if ( this.diffElement ) {
- this.diffElement.destroy();
this.diffElement = null;
this.diffElementPromise = null;
this.getDiffElementPromise = null;
@@ -622,20 +621,46 @@
if ( !this.diffElementPromise ) {
this.diffElementPromise =
this.getDiffElementPromise().then( function( diffElement ) {
dialog.diffElement = diffElement;
- dialog.$reviewVisualDiff.append(
diffElement.$element );
- diffElement.positionDescriptions();
- dialog.updateSize();
+
dialog.$reviewVisualDiff.empty().append( diffElement.$element );
+ dialog.positionDiffElement();
} );
}
return;
}
- this.diffElement.positionDescriptions();
+ this.positionDiffElement();
}
this.updateSize();
};
/**
* @inheritdoc
+ */
+ve.ui.MWSaveDialog.prototype.setDimensions = function () {
+ // Parent method
+ ve.ui.MWSaveDialog.parent.prototype.setDimensions.apply( this,
arguments );
+
+ this.positionDiffElement();
+};
+
+/**
+ * Re-position elements within the diff element
+ *
+ * Should be called whenever the diff element's container has changed width.
+ */
+ve.ui.MWSaveDialog.prototype.positionDiffElement = function () {
+ var dialog = this;
+ if ( this.diffElement && this.panels.getCurrentItem() ===
this.reviewPanel ) {
+ setTimeout( function () {
+ dialog.withoutSizeTransitions( function () {
+ dialog.diffElement.positionDescriptions();
+ dialog.updateSize();
+ } );
+ }, OO.ui.theme.getDialogTransitionDuration() );
+ }
+};
+
+/**
+ * @inheritdoc
* @param {Object} [data]
* @param {boolean} [data.canReview] User can review changes
* @param {boolean} [data.canPreview] User can preview changes
--
To view, visit https://gerrit.wikimedia.org/r/347358
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I912a99edca25ff576e2872723f91afe54e36a170
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Esanders <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
