Awight has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/347525 )

Change subject: Rename confusing use of "job tag"
......................................................................

Rename confusing use of "job tag"

Change-Id: I961bc4dc331837d974465a18f570b088fa629952
---
M processcontrol/lock.py
M processcontrol/runner.py
2 files changed, 3 insertions(+), 3 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/process-control 
refs/changes/25/347525/1

diff --git a/processcontrol/lock.py b/processcontrol/lock.py
index 38e6c67..f913139 100644
--- a/processcontrol/lock.py
+++ b/processcontrol/lock.py
@@ -18,8 +18,8 @@
 
 
 # TODO: Decide whether we want to failopen?
-def begin(failopen=False, job_tag=None):
-    filename = path_for_job(job_tag)
+def begin(failopen=False, slug=None):
+    filename = path_for_job(slug)
 
     if os.path.exists(filename):
         config.log.error("Lockfile found!")
diff --git a/processcontrol/runner.py b/processcontrol/runner.py
index f4e6fa9..fb40a05 100644
--- a/processcontrol/runner.py
+++ b/processcontrol/runner.py
@@ -31,7 +31,7 @@
             passwd_entry = pwd.getpwnam(service_user)
         assert passwd_entry.pw_uid == os.getuid()
 
-        lock.begin(job_tag=self.job.slug)
+        lock.begin(slug=self.job.slug)
         self.start_time = datetime.datetime.utcnow()
         job_history = job_state.load_state(self.job.slug)
         job_history.record_started(self.start_time)

-- 
To view, visit https://gerrit.wikimedia.org/r/347525
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I961bc4dc331837d974465a18f570b088fa629952
Gerrit-PatchSet: 1
Gerrit-Project: wikimedia/fundraising/process-control
Gerrit-Branch: master
Gerrit-Owner: Awight <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to