jenkins-bot has submitted this change and it was merged.

Change subject: Regression: Do not enable random module on special pages
......................................................................


Regression: Do not enable random module on special pages

Currently incompatible and causes breakage

Change-Id: I5423eca2bd9f4e1715e239a802c37f7ecc030e7b
---
M javascripts/modules/mf-random.js
1 file changed, 3 insertions(+), 2 deletions(-)

Approvals:
  MaxSem: Verified; Looks good to me, approved
  jenkins-bot: Verified



diff --git a/javascripts/modules/mf-random.js b/javascripts/modules/mf-random.js
index 683f927..6884405 100644
--- a/javascripts/modules/mf-random.js
+++ b/javascripts/modules/mf-random.js
@@ -1,6 +1,7 @@
 ( function( M,  $ ) {
 var m = ( function() {
-       var randomPageReq;
+       var randomPageReq,
+               isSpecialPage = mw.config.get( 'wgNamespaceNumber' ) ===  
mw.config.get( 'wgNamespaceIds' ).special;
 
        function makeHeader( articles ) {
                var $list, $c;
@@ -62,7 +63,7 @@
        }
 
        return {
-               init: M.history.supportsHistoryApi ? init : $.noop
+               init: M.history.supportsHistoryApi && !isSpecialPage ? init : 
$.noop
        };
 }() );
 

-- 
To view, visit https://gerrit.wikimedia.org/r/51206
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I5423eca2bd9f4e1715e239a802c37f7ecc030e7b
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson <jrob...@wikimedia.org>
Gerrit-Reviewer: JGonera <jgon...@wikimedia.org>
Gerrit-Reviewer: Jdlrobson <jrob...@wikimedia.org>
Gerrit-Reviewer: MaxSem <maxsem.w...@gmail.com>
Gerrit-Reviewer: jenkins-bot

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to