jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/347839 )
Change subject: Add statsd tracking to CheckConstraints API
......................................................................
Add statsd tracking to CheckConstraints API
Change-Id: I05c538b1e6bb54d2a2fb1f15b7c62648b9401c0a
---
M api/CheckConstraints.php
1 file changed, 20 insertions(+), 29 deletions(-)
Approvals:
Lucas Werkmeister (WMDE): Looks good to me, but someone else must approve
jenkins-bot: Verified
Thiemo Mättig (WMDE): Looks good to me, approved
diff --git a/api/CheckConstraints.php b/api/CheckConstraints.php
index 00a5f8f..bf710d0 100644
--- a/api/CheckConstraints.php
+++ b/api/CheckConstraints.php
@@ -5,44 +5,32 @@
use ApiBase;
use ApiMain;
use ApiResult;
-use DataValues\DataValue;
-use Wikibase\DataModel\Entity\EntityIdValue;
-use Wikibase\DataModel\Services\EntityId\EntityIdFormatter;
-
+use Language;
+use MediaWiki\MediaWikiServices;
use RequestContext;
-
+use ValueFormatters\FormatterOptions;
+use Wikibase\ChangeOp\StatementChangeOpFactory;
use Wikibase\DataModel\Entity\EntityId;
-
use Wikibase\DataModel\Entity\EntityIdParser;
use Wikibase\DataModel\Entity\EntityIdParsingException;
-use Wikibase\DataModel\Services\Statement\StatementGuidValidator;
+use Wikibase\DataModel\Entity\PropertyId;
+use Wikibase\DataModel\Services\EntityId\EntityIdFormatter;
+use Wikibase\DataModel\Services\Lookup\TermLookup;
use Wikibase\DataModel\Services\Statement\StatementGuidParser;
-use Wikibase\Repo\Api\ApiErrorReporter;
-use Wikibase\Repo\Api\ApiHelperFactory;
-
-use Wikibase\Repo\WikibaseRepo;
-
-use WikibaseQuality\ConstraintReport\ConstraintReportFactory;
-use
WikibaseQuality\ConstraintReport\ConstraintCheck\DelegatingConstraintChecker;
-
-use Wikibase\Repo\EntityIdLabelFormatterFactory;
-use ValueFormatters\FormatterOptions;
+use Wikibase\DataModel\Services\Statement\StatementGuidValidator;
+use Wikibase\DataModel\Services\Term\TermBuffer;
+use Wikibase\LanguageFallbackChainFactory;
use Wikibase\Lib\OutputFormatValueFormatterFactory;
use Wikibase\Lib\SnakFormatter;
-
-use WikibaseQuality\ConstraintReport\ConstraintParameterRenderer;
use Wikibase\Lib\Store\LanguageFallbackLabelDescriptionLookupFactory;
-
-use Wikibase\DataModel\Entity\ItemId;
-use Wikibase\DataModel\Entity\PropertyId;
-
-use Wikibase\ChangeOp\StatementChangeOpFactory;
-use Wikibase\LanguageFallbackChain;
-use Wikibase\LanguageFallbackChainFactory;
-use Wikibase\DataModel\Services\Lookup\TermLookup;
-use Wikibase\DataModel\Services\Term\TermBuffer;
+use Wikibase\Repo\Api\ApiErrorReporter;
+use Wikibase\Repo\Api\ApiHelperFactory;
+use Wikibase\Repo\EntityIdLabelFormatterFactory;
+use Wikibase\Repo\WikibaseRepo;
+use
WikibaseQuality\ConstraintReport\ConstraintCheck\DelegatingConstraintChecker;
+use WikibaseQuality\ConstraintReport\ConstraintParameterRenderer;
+use WikibaseQuality\ConstraintReport\ConstraintReportFactory;
use Wikimedia\Assert\Assert;
-use Language;
/**
* API module that performs constraint check of entities, claims and
constraint ID
@@ -184,6 +172,9 @@
* Evaluates the parameters, runs the requested constraint check, and
sets up the result
*/
public function execute() {
+ MediaWikiServices::getInstance()->getStatsdDataFactory()
+ ->increment(
'wikibase.quality.constraints.api.checkConstraints.execute' );
+
$params = $this->extractRequestParams();
$output = [];
--
To view, visit https://gerrit.wikimedia.org/r/347839
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I05c538b1e6bb54d2a2fb1f15b7c62648b9401c0a
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikibaseQualityConstraints
Gerrit-Branch: master
Gerrit-Owner: Jonas Kress (WMDE) <[email protected]>
Gerrit-Reviewer: Addshore <[email protected]>
Gerrit-Reviewer: Lucas Werkmeister (WMDE) <[email protected]>
Gerrit-Reviewer: Thiemo Mättig (WMDE) <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
