jenkins-bot has submitted this change and it was merged.
Change subject: Correct documentation for wfPickRandom()'s return types
......................................................................
Correct documentation for wfPickRandom()'s return types
Also make LoadBalancer::pickRandom()'s one consistent.
Change-Id: Ib80827ef20b32fecb799f327545b1232272076d2
---
M includes/GlobalFunctions.php
M includes/db/LoadBalancer.php
2 files changed, 2 insertions(+), 2 deletions(-)
Approvals:
Aaron Schulz: Looks good to me, approved
jenkins-bot: Verified
diff --git a/includes/GlobalFunctions.php b/includes/GlobalFunctions.php
index 121d6ca..b49ca65 100644
--- a/includes/GlobalFunctions.php
+++ b/includes/GlobalFunctions.php
@@ -335,7 +335,7 @@
*
* @param $weights array
*
- * @return int|string
+ * @return bool|int|string
*/
function wfPickRandom( $weights ){
if ( !is_array( $weights ) || count( $weights ) == 0 ) {
diff --git a/includes/db/LoadBalancer.php b/includes/db/LoadBalancer.php
index d249c27..311691d 100644
--- a/includes/db/LoadBalancer.php
+++ b/includes/db/LoadBalancer.php
@@ -121,7 +121,7 @@
*
* @param $weights array
*
- * @return int
+ * @return bool|int|string
*/
function pickRandom( $weights ) {
return wfPickRandom( $weights );
--
To view, visit https://gerrit.wikimedia.org/r/51638
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib80827ef20b32fecb799f327545b1232272076d2
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: IAlex <[email protected]>
Gerrit-Reviewer: Aaron Schulz <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
