WMDE-Fisch has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/348051 )
Change subject: Make more use of the RevisionListView element
......................................................................
Make more use of the RevisionListView element
Change-Id: I67a07c046aa5f9c2e1f79407efc87f222c00e813
---
M modules/ext.RevisionSlider.SliderViewTwo.js
1 file changed, 8 insertions(+), 4 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/RevisionSlider
refs/changes/51/348051/1
diff --git a/modules/ext.RevisionSlider.SliderViewTwo.js
b/modules/ext.RevisionSlider.SliderViewTwo.js
index 7bee923..2abb176 100644
--- a/modules/ext.RevisionSlider.SliderViewTwo.js
+++ b/modules/ext.RevisionSlider.SliderViewTwo.js
@@ -119,7 +119,7 @@
return pos;
}
- $revisions = $( '.mw-revslider-revisions' );
+ $revisions = this.getRevisonsElement();
$hoveredRevisionWrapper = this.getRevElementAtPosition(
$revisions, pos ).parent();
this.slider.getRevisions().getView().showTooltip(
$hoveredRevisionWrapper );
@@ -147,7 +147,7 @@
},
showTooltipsOnMouseMoveHandler: function( event,
lastValidPosition ) {
- var $revisions =
this.slider.getRevisions().getView().getElement(),
+ var $revisions = this.getRevisonsElement(),
revisionsX = $revisions.offset().left,
pos = Math.ceil( Math.abs( event.pageX -
revisionsX ) / this.revisionWidth ),
$hoveredRevisionWrapper;
@@ -168,7 +168,7 @@
},
sliderLineClickHandler: function( event, $line ) {
- var $revisions = this.$element.find(
'.mw-revslider-revisions' ),
+ var $revisions = this.getRevisonsElement(),
$clickedRev = this.getRevisionNearestToClick(
event ),
pointerMoved, pointerOther, newPosition;
@@ -197,7 +197,7 @@
},
getRevisionNearestToClick: function( clickEvent ) {
- var $revisionArr = $( '.mw-revslider-revision' ),
+ var $revisionArr = this.getRevisonsElement().find(
'.mw-revslider-revision' ),
$current, rtlOffset, i = 0, count;
rtlOffset = this.dir === 'rtl' ? this.revisionWidth : 0;
@@ -272,6 +272,10 @@
return this.pointerNewer.getPosition() -
this.pointerOlder.getPosition();
},
+ getRevisonsElement: function() {
+ return
this.slider.getRevisions().getView().getElement();
+ },
+
revisionWrapperClickHandler: function() {
}
} );
--
To view, visit https://gerrit.wikimedia.org/r/348051
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I67a07c046aa5f9c2e1f79407efc87f222c00e813
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/RevisionSlider
Gerrit-Branch: master
Gerrit-Owner: WMDE-Fisch <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
