Reedy has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/348063 )

Change subject: jQuery-ify some code
......................................................................

jQuery-ify some code

Fix suggested by PeterBodifee

Bug: T162264
Change-Id: Ia68b69e2bee29493abcf0d5589869a1b6cf269f1
---
M DiscussionThreading.class.php
1 file changed, 5 insertions(+), 6 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/DiscussionThreading 
refs/changes/63/348063/1

diff --git a/DiscussionThreading.class.php b/DiscussionThreading.class.php
index a81b7e7..3b2f841 100644
--- a/DiscussionThreading.class.php
+++ b/DiscussionThreading.class.php
@@ -97,9 +97,9 @@
                                // Insert javascript hook that will select the 
replace me text
                                global $wgOut;
                                $wgOut->addScript("<script 
type=\"text/javascript\">
-function efDiscussionThread(){
-       var ctrl = document.editform.wpTextbox1;
-       if (ctrl.setSelectionRange) {
+jQuery ( function ( $ ) {
+               var ctrl = document.editform.wpTextbox1;
+               if (ctrl.setSelectionRange) {
                ctrl.focus();
                var end = ctrl.value.length;
                ctrl.setSelectionRange(end-".strlen($replaceMeText).",end-1);
@@ -110,9 +110,8 @@
                range.moveStart('character', -".strlen($replaceMeText).");
                range.select();
        }
-}
-addOnloadHook(efDiscussionThread);
-                       </script>"
+} );
+</script>"
                                );
                                $efform->replyadded = true;
                                $efform->textbox1 = $text;

-- 
To view, visit https://gerrit.wikimedia.org/r/348063
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia68b69e2bee29493abcf0d5589869a1b6cf269f1
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/DiscussionThreading
Gerrit-Branch: master
Gerrit-Owner: Reedy <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to