Bsitu has submitted this change and it was merged.
Change subject: Remove a couple of unused variables
......................................................................
Remove a couple of unused variables
Change-Id: I45e0b6e7c2ae8e2235ff8f85c95c657e0e05fc9e
---
M formatters/CommentFormatter.php
M includes/EmailBatch.php
2 files changed, 1 insertion(+), 6 deletions(-)
Approvals:
Bsitu: Verified; Looks good to me, approved
jenkins-bot: Checked
diff --git a/formatters/CommentFormatter.php b/formatters/CommentFormatter.php
index ac805fb..a7e60ee 100644
--- a/formatters/CommentFormatter.php
+++ b/formatters/CommentFormatter.php
@@ -55,11 +55,6 @@
$message->params( '' );
}
} elseif ( $param === 'commentText' ) {
- /**
- * @var $wgLang Language
- */
- global $wgLang; // Message::language is protected :(
-
if ( isset( $extra['content'] ) && $extra['content'] ) {
$content = $extra['content'];
$content = EchoDiscussionParser::stripHeader(
$content );
diff --git a/includes/EmailBatch.php b/includes/EmailBatch.php
index d86e2d9..4aedf6f 100644
--- a/includes/EmailBatch.php
+++ b/includes/EmailBatch.php
@@ -100,7 +100,7 @@
$events = $this->getEvents();
if ( $events ) {
- foreach( $events as $batchId => $row ) {
+ foreach( $events as $row ) {
$this->count++;
if ( $this->count > self::$displaySize ) {
break;
--
To view, visit https://gerrit.wikimedia.org/r/51592
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I45e0b6e7c2ae8e2235ff8f85c95c657e0e05fc9e
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Echo
Gerrit-Branch: master
Gerrit-Owner: Reedy <re...@wikimedia.org>
Gerrit-Reviewer: Bsitu <bs...@wikimedia.org>
Gerrit-Reviewer: Kaldari <rkald...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
