jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/347328 )
Change subject: Remove unused code from SidebarHookHandlersTest
......................................................................
Remove unused code from SidebarHookHandlersTest
Please review this carefully! I do not understand what the code I'm
removing in this patch was meant to do originally. This unused code may
be the result of the refactoring done in I221802a. Or is the test broken
and becomes antirely useless when I remove this?
Change-Id: I33289f88fae06c07b519b24ad4f4bc7ce6ab4844
---
M client/tests/phpunit/includes/Hooks/SidebarHookHandlersTest.php
1 file changed, 3 insertions(+), 33 deletions(-)
Approvals:
WMDE-leszek: Looks good to me, but someone else must approve
Hoo man: Looks good to me, approved
jenkins-bot: Verified
Thiemo Mättig (WMDE): Looks good to me, but someone else must approve
diff --git a/client/tests/phpunit/includes/Hooks/SidebarHookHandlersTest.php
b/client/tests/phpunit/includes/Hooks/SidebarHookHandlersTest.php
index b2ca548..1b18ca0 100644
--- a/client/tests/phpunit/includes/Hooks/SidebarHookHandlersTest.php
+++ b/client/tests/phpunit/includes/Hooks/SidebarHookHandlersTest.php
@@ -14,10 +14,7 @@
use Wikibase\Client\Hooks\OtherProjectsSidebarGeneratorFactory;
use Wikibase\Client\Hooks\SidebarHookHandlers;
use Wikibase\Client\WikibaseClient;
-use Wikibase\DataModel\Entity\Item;
-use Wikibase\DataModel\Entity\ItemId;
use Wikibase\DataModel\Services\Lookup\LabelDescriptionLookup;
-use Wikibase\DataModel\SiteLink;
use Wikibase\NamespaceChecker;
use Wikibase\SettingsArray;
@@ -33,23 +30,11 @@
*/
class SidebarHookHandlersTest extends \MediaWikiTestCase {
- private function getBadgeItem() {
- $item = new Item( new ItemId( 'Q17' ) );
- $item->setLabel( 'de', 'exzellent' );
- $item->setLabel( 'en', 'featured' );
-
- return $item;
- }
-
/**
- * @param array[] $siteLinksPerItem
- *
* @return LabelDescriptionLookup
*/
- private function getLabelDescriptionLookup( array $siteLinksPerItem ) {
- $labelLookup = $this->getMockBuilder(
LabelDescriptionLookup::class )
- ->disableOriginalConstructor()
- ->getMock();
+ private function getLabelDescriptionLookup() {
+ $labelLookup = $this->getMock( LabelDescriptionLookup::class );
$labelLookup->expects( $this->any() )
->method( 'getLabel' )
@@ -115,21 +100,6 @@
}
private function newSidebarHookHandlers( array $settings = array() ) {
- $badgeId = $this->getBadgeItem()->getId();
-
- $siteLinksPerItem = array(
- 'Q1' => array(
- new SiteLink( 'dewiki', 'Sauerstoff', array(
$badgeId ) ),
- new SiteLink( 'enwiki', 'Oxygen' ),
- new SiteLink( 'commonswiki', 'Oxygen' ),
- ),
- 'Q7' => array(
- new SiteLink( 'dewiki', 'User:Foo' ),
- new SiteLink( 'enwiki', 'User:Foo' ),
- new SiteLink( 'commonswiki', 'User:Foo' ),
- ),
- );
-
$en = Language::factory( 'en' );
$settings = $this->newSettings( $settings );
@@ -137,7 +107,7 @@
$namespaceChecker = new NamespaceChecker( array(), $namespaces
);
$badgeDisplay = new LanguageLinkBadgeDisplay(
- $this->getLabelDescriptionLookup( $siteLinksPerItem ),
+ $this->getLabelDescriptionLookup(),
array( 'Q17' => 'featured' ),
$en
);
--
To view, visit https://gerrit.wikimedia.org/r/347328
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I33289f88fae06c07b519b24ad4f4bc7ce6ab4844
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Thiemo Mättig (WMDE) <[email protected]>
Gerrit-Reviewer: Addshore <[email protected]>
Gerrit-Reviewer: Aude <[email protected]>
Gerrit-Reviewer: Hoo man <[email protected]>
Gerrit-Reviewer: Thiemo Mättig (WMDE) <[email protected]>
Gerrit-Reviewer: WMDE-leszek <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
