WMDE-Fisch has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/348102 )

Change subject: Fix OOjs UI tooltip position
......................................................................

Fix OOjs UI tooltip position

The latest OOjs UI update seem to fix tooltip center positioning.
Margins added manually are removed now.

Change-Id: I883a5026002fae6fbda230b407303a4f2b82914d
---
M modules/ext.RevisionSlider.RevisionListView.js
M modules/ext.RevisionSlider.css
2 files changed, 0 insertions(+), 13 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/RevisionSlider 
refs/changes/02/348102/1

diff --git a/modules/ext.RevisionSlider.RevisionListView.js 
b/modules/ext.RevisionSlider.RevisionListView.js
index 8e0fec3..0f9a871 100644
--- a/modules/ext.RevisionSlider.RevisionListView.js
+++ b/modules/ext.RevisionSlider.RevisionListView.js
@@ -150,11 +150,6 @@
                        this.hideCurrentTooltip();
 
                        tooltip = this.makeTooltip( revision, 
$revisionContainer );
-                       if ( this.dir === 'ltr' ) {
-                               tooltip.$element.css( 'margin-left', 
this.revisionWidth / 2 + 'px' );
-                       } else {
-                               tooltip.$element.css( 'margin-right', 
this.revisionWidth / 2 + 'px' );
-                       }
                        tooltip.$element.addClass( 
'mw-revslider-revision-tooltip-' + pos );
 
                        $( 'body' ).append( tooltip.$element );
diff --git a/modules/ext.RevisionSlider.css b/modules/ext.RevisionSlider.css
index c2a5ae8..32428e3 100644
--- a/modules/ext.RevisionSlider.css
+++ b/modules/ext.RevisionSlider.css
@@ -126,14 +126,6 @@
        text-align: center;
 }
 
-.mw-revslider-arrow-tooltip {
-       margin-left: 10px;
-}
-
-.mw-revslider-help-tooltip {
-       margin-left: 13px;
-}
-
 .mw-revslider-revisions {
        height: 140px;
        white-space: nowrap;

-- 
To view, visit https://gerrit.wikimedia.org/r/348102
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I883a5026002fae6fbda230b407303a4f2b82914d
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/RevisionSlider
Gerrit-Branch: master
Gerrit-Owner: WMDE-Fisch <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to