Hoo man has submitted this change and it was merged.
Change subject: Used empty string instead of null for lock in
setglobalaccountstatus API
......................................................................
Used empty string instead of null for lock in setglobalaccountstatus API
For this kind of unset value, no other API module uses null.
Also, null causes invalid XML from paraminfo.
Change-Id: I54295e81b68db44770aaf1f0e8df7d0a4d807505
---
M api/ApiSetGlobalAccountStatus.php
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Hoo man: Verified; Looks good to me, approved
jenkins-bot: Checked
diff --git a/api/ApiSetGlobalAccountStatus.php
b/api/ApiSetGlobalAccountStatus.php
index 38ce990..5cf2407 100644
--- a/api/ApiSetGlobalAccountStatus.php
+++ b/api/ApiSetGlobalAccountStatus.php
@@ -153,7 +153,7 @@
ApiBase::PARAM_TYPE => array(
'lock',
'unlock',
- null // Unset - basically means 'do not
modify lock status'
+ '' // Unset - basically means 'do not
modify lock status'
)
),
'hidden' => array(
--
To view, visit https://gerrit.wikimedia.org/r/45362
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I54295e81b68db44770aaf1f0e8df7d0a4d807505
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/CentralAuth
Gerrit-Branch: master
Gerrit-Owner: Petr Onderka <[email protected]>
Gerrit-Reviewer: Alex Monk <[email protected]>
Gerrit-Reviewer: Anomie <[email protected]>
Gerrit-Reviewer: CSteipp <[email protected]>
Gerrit-Reviewer: Hoo man <[email protected]>
Gerrit-Reviewer: Petr Onderka <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
