Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/348139 )
Change subject: build: Remove 'grunt watch'
......................................................................
build: Remove 'grunt watch'
I don't think anyone uses this much and is quite a hack to maintain.
Change-Id: Id33696a1c4276a44f33395061273e5ec4c01991c
---
M Gruntfile.js
M package.json
2 files changed, 0 insertions(+), 18 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/unicodejs refs/changes/39/348139/1
diff --git a/Gruntfile.js b/Gruntfile.js
index ce5fe3e..80de880 100644
--- a/Gruntfile.js
+++ b/Gruntfile.js
@@ -7,13 +7,9 @@
grunt.loadNpmTasks( 'grunt-contrib-clean' );
grunt.loadNpmTasks( 'grunt-contrib-concat' );
- grunt.loadNpmTasks( 'grunt-contrib-watch' );
grunt.loadNpmTasks( 'grunt-eslint' );
grunt.loadNpmTasks( 'grunt-karma' );
grunt.loadTasks( 'build/tasks' );
-
- // We want to use `grunt watch` to start this and karma watch together.
- grunt.renameTask( 'watch', 'runwatch' );
grunt.initConfig( {
pkg: grunt.file.readJSON( 'package.json' ),
@@ -56,19 +52,7 @@
},
local: {
browsers: [ 'Firefox', 'Chrome' ]
- },
- bg: {
- browsers: [ 'PhantomJS', 'Firefox', 'Chrome' ],
- singleRun: false,
- background: true
}
- },
- runwatch: {
- files: [
- '.eslintrc.json',
- '<%= elhint.all %>'
- ],
- tasks: [ 'test', 'karma:bg:run' ]
}
} );
@@ -76,6 +60,5 @@
grunt.registerTask( 'lint', [ 'eslint' ] );
grunt.registerTask( 'unit', [ 'karma:phantomjs' ] );
grunt.registerTask( 'test', [ 'git-build', 'build', 'lint', 'unit' ] );
- grunt.registerTask( 'watch', [ 'karma:bg:start', 'runwatch' ] );
grunt.registerTask( 'default', 'test' );
};
diff --git a/package.json b/package.json
index 23e5d20..958143c 100644
--- a/package.json
+++ b/package.json
@@ -23,7 +23,6 @@
"grunt-contrib-clean": "1.0.0",
"grunt-contrib-concat": "1.0.1",
"grunt-eslint": "19.0.0",
- "grunt-contrib-watch": "1.0.0",
"grunt-karma": "1.0.0",
"karma": "1.1.0",
"karma-chrome-launcher": "1.0.1",
--
To view, visit https://gerrit.wikimedia.org/r/348139
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id33696a1c4276a44f33395061273e5ec4c01991c
Gerrit-PatchSet: 1
Gerrit-Project: unicodejs
Gerrit-Branch: master
Gerrit-Owner: Krinkle <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
