jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/348144 )
Change subject: qunit: Remove test for deprecated jquery.placeholder
......................................................................
qunit: Remove test for deprecated jquery.placeholder
It's not very useful and needlessly emits deprecation warnings
which unfortunately cannot be surpressed at runtime.
The test just asserts that a no-op function exists.
Change-Id: I2768ba40191a3c0cc7be6202ffa5bed529eabfee
---
M tests/qunit/QUnitTestResources.php
D tests/qunit/suites/resources/jquery/jquery.placeholder.test.js
2 files changed, 0 insertions(+), 10 deletions(-)
Approvals:
jenkins-bot: Verified
Jforrester: Looks good to me, approved
diff --git a/tests/qunit/QUnitTestResources.php
b/tests/qunit/QUnitTestResources.php
index 6468646..53362c4 100644
--- a/tests/qunit/QUnitTestResources.php
+++ b/tests/qunit/QUnitTestResources.php
@@ -57,7 +57,6 @@
'tests/qunit/suites/resources/jquery/jquery.localize.test.js',
'tests/qunit/suites/resources/jquery/jquery.makeCollapsible.test.js',
'tests/qunit/suites/resources/jquery/jquery.mwExtension.test.js',
-
'tests/qunit/suites/resources/jquery/jquery.placeholder.test.js',
'tests/qunit/suites/resources/jquery/jquery.tabIndex.test.js',
'tests/qunit/suites/resources/jquery/jquery.tablesorter.test.js',
'tests/qunit/suites/resources/jquery/jquery.tablesorter.parsers.test.js',
@@ -113,7 +112,6 @@
'jquery.localize',
'jquery.makeCollapsible',
'jquery.mwExtension',
- 'jquery.placeholder',
'jquery.tabIndex',
'jquery.tablesorter',
'jquery.textSelection',
diff --git a/tests/qunit/suites/resources/jquery/jquery.placeholder.test.js
b/tests/qunit/suites/resources/jquery/jquery.placeholder.test.js
deleted file mode 100644
index ed2fbe6..0000000
--- a/tests/qunit/suites/resources/jquery/jquery.placeholder.test.js
+++ /dev/null
@@ -1,8 +0,0 @@
-( function ( $ ) {
- QUnit.module( 'jquery.placeholder', QUnit.newMwEnvironment() );
-
- QUnit.test( 'caches results of feature tests', function ( assert ) {
- assert.strictEqual( typeof $.fn.placeholder.input, 'boolean',
'$.fn.placeholder.input' );
- assert.strictEqual( typeof $.fn.placeholder.textarea,
'boolean', '$.fn.placeholder.textarea' );
- } );
-}( jQuery ) );
--
To view, visit https://gerrit.wikimedia.org/r/348144
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2768ba40191a3c0cc7be6202ffa5bed529eabfee
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Krinkle <[email protected]>
Gerrit-Reviewer: Jforrester <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
