Jforrester has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/348167 )
Change subject: Removed deprecated ExtractThumbParameters hook
......................................................................
Removed deprecated ExtractThumbParameters hook
Change-Id: I97e820d78d8041c40fb6e553c4081c676602462c
---
M RELEASE-NOTES-1.29
M docs/hooks.txt
M thumb.php
3 files changed, 1 insertion(+), 16 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/67/348167/1
diff --git a/RELEASE-NOTES-1.29 b/RELEASE-NOTES-1.29
index f9ff2e3..117a65c 100644
--- a/RELEASE-NOTES-1.29
+++ b/RELEASE-NOTES-1.29
@@ -327,6 +327,7 @@
mwCustomEditButtons, injectSpinner, removeSpinner, escapeQuotes,
escapeQuotesHTML, jsMsg, addPortletLink, appendCSS, tooltipAccessKeyPrefix,
tooltipAccessKeyRegexp, updateTooltipAccessKeys.
+* The ExtractThumbParameters hook (deprecated in 1.21) was removed.
== Compatibility ==
diff --git a/docs/hooks.txt b/docs/hooks.txt
index 060af89..51fdbec 100644
--- a/docs/hooks.txt
+++ b/docs/hooks.txt
@@ -1519,13 +1519,6 @@
change the tables headers.
&$extTypes: associative array of extensions types
-'ExtractThumbParameters': DEPRECATED! Media handler should override
-MediaHandler::parseParamString instead.
-Called when extracting thumbnail parameters from a thumbnail file name.
-$thumbname: the base name of the thumbnail file
-&$params: the currently extracted params (has source name, temp or archived
-zone)
-
'FetchChangesList': When fetching the ChangesList derivative for a particular
user.
$user: User the list is being fetched for
diff --git a/thumb.php b/thumb.php
index d97f8e8..7c3e757 100644
--- a/thumb.php
+++ b/thumb.php
@@ -530,15 +530,6 @@
$thumbname = $params['thumbName'];
unset( $params['thumbName'] );
- // Do the hook first for older extensions that rely on it.
- if ( !Hooks::run( 'ExtractThumbParameters', [ $thumbname, &$params ] )
) {
- // Check hooks if parameters can be extracted
- // Hooks return false if they manage to *resolve* the parameters
- // This hook should be considered deprecated
- wfDeprecated( 'ExtractThumbParameters', '1.22' );
- return $params; // valid thumbnail URL (via extension or config)
- }
-
// FIXME: Files in the temp zone don't set a MIME type, which means
// they don't have a handler. Which means we can't parse the param
// string. However, not a big issue as what good is a param string
--
To view, visit https://gerrit.wikimedia.org/r/348167
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I97e820d78d8041c40fb6e553c4081c676602462c
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Jforrester <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
