Florianschmidtwelzow has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/348468 )
Change subject: Removw usage of RequestContext::getStats() ...................................................................... Removw usage of RequestContext::getStats() Bug: T156810 Change-Id: I985b22f8d0235e132c0c34a51da4bea992432209 --- M WikimediaEventsHooks.php 1 file changed, 7 insertions(+), 7 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/WikimediaEvents refs/changes/68/348468/1 diff --git a/WikimediaEventsHooks.php b/WikimediaEventsHooks.php index 821077a..b15e62f 100644 --- a/WikimediaEventsHooks.php +++ b/WikimediaEventsHooks.php @@ -70,13 +70,13 @@ return; } + $stats = MediaWikiServices::getInstance()->getStatsdDataFactory(); if ( PHP_SAPI !== 'cli' ) { - DeferredUpdates::addCallableUpdate( function () { - $context = RequestContext::getMain(); - $timing = $context->getTiming(); + DeferredUpdates::addCallableUpdate( function () use ( $stats ) { + $timing = RequestContext::getMain()->getTiming(); $measure = $timing->measure( 'editResponseTime', 'requestStart', 'requestShutdown' ); if ( $measure !== false ) { - $context->getStats()->timing( 'timing.editResponseTime', $measure['duration'] * 1000 ); + $stats->timing( 'timing.editResponseTime', $measure['duration'] * 1000 ); } } ); } @@ -113,7 +113,6 @@ // are important indicators of community health. if ( $editCount === 0 || preg_match( '/^9+$/' , "$editCount" ) ) { $milestone = $editCount + 1; - $stats = RequestContext::getMain()->getStats(); $stats->increment( "editor.milestones.{$milestone}" ); $stats->timing( "editor.milestones.timing.{$milestone}", $age ); } @@ -182,7 +181,8 @@ if ( $numMainspaceEditsThisMonth === 5 ) { $month = date( 'm-Y' ); - $context->getStats()->increment( 'editor.activation.' . $month ); + MediaWikiServices::getInstance() + ->getStatsdDataFactory()->increment( 'editor.activation.' . $month ); EventLogging::logEvent( 'EditorActivation', 14208837, array( 'userId' => $user->getId(), 'month' => $month, @@ -519,7 +519,7 @@ $measure = $timing->measure( 'viewResponseTime', 'requestStart', 'requestShutdown' ); if ( $measure !== false ) { - $context->getStats()->timing( + MediaWikiServices::getInstance()->getStatsdDataFactory()->timing( "timing.viewResponseTime.{$platform}", $measure['duration'] * 1000 ); } } ); -- To view, visit https://gerrit.wikimedia.org/r/348468 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I985b22f8d0235e132c0c34a51da4bea992432209 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/WikimediaEvents Gerrit-Branch: master Gerrit-Owner: Florianschmidtwelzow <florian.schmidt.stargatewis...@gmail.com> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits