jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/348192 )
Change subject: Clarify getLaggedReplicaMode()/laggedReplicaUsed() in
LoadBalancer
......................................................................
Clarify getLaggedReplicaMode()/laggedReplicaUsed() in LoadBalancer
Change-Id: I4ea9033d2d643c6758c49f34a69c9837598eea33
---
M includes/libs/rdbms/loadbalancer/ILoadBalancer.php
1 file changed, 6 insertions(+), 2 deletions(-)
Approvals:
Krinkle: Looks good to me, approved
jenkins-bot: Verified
diff --git a/includes/libs/rdbms/loadbalancer/ILoadBalancer.php
b/includes/libs/rdbms/loadbalancer/ILoadBalancer.php
index cbd0ff3..dbf653d 100644
--- a/includes/libs/rdbms/loadbalancer/ILoadBalancer.php
+++ b/includes/libs/rdbms/loadbalancer/ILoadBalancer.php
@@ -444,13 +444,17 @@
/**
* @note This method will trigger a DB connection if not yet done
* @param string|bool $domain Domain ID, or false for the current domain
- * @return bool Whether the generic connection for reads is highly
"lagged"
+ * @return bool Whether the database for generic connections this
request is highly "lagged"
*/
public function getLaggedReplicaMode( $domain = false );
/**
+ * Checks whether the database for generic connections this request was
both:
+ * - a) Already choosen due to a prior connection attempt
+ * - b) Considered highly "lagged"
+ *
* @note This method will never cause a new DB connection
- * @return bool Whether any generic connection used for reads was
highly "lagged"
+ * @return bool
*/
public function laggedReplicaUsed();
--
To view, visit https://gerrit.wikimedia.org/r/348192
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4ea9033d2d643c6758c49f34a69c9837598eea33
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Aaron Schulz <[email protected]>
Gerrit-Reviewer: Aaron Schulz <[email protected]>
Gerrit-Reviewer: Krinkle <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
