Phuedx has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/348919 )
Change subject: Foo
......................................................................
Foo
Change-Id: I1acdfc15237d1d91e144b9fa5933ab6b3cfd9186
---
M tests/node-qunit/actions.test.js
1 file changed, 5 insertions(+), 8 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Popups
refs/changes/19/348919/1
diff --git a/tests/node-qunit/actions.test.js b/tests/node-qunit/actions.test.js
index 0732bbd..739c6ab 100644
--- a/tests/node-qunit/actions.test.js
+++ b/tests/node-qunit/actions.test.js
@@ -409,8 +409,7 @@
activeToken: token
}
};
- },
- done = assert.async();
+ };
this.sandbox.stub( mw, 'now' ).returns( new Date() );
@@ -429,7 +428,10 @@
'Have you spoken with #Design about changing this value?'
);
- this.waitPromises[ 0 ].then( function () {
+ // After ABANDON_END_DELAY milliseconds...
+ this.waitDeferreds[ 0 ].resolve();
+
+ return this.waitPromises[ 0 ].then( function () {
assert.ok(
dispatch.calledWith( {
type: 'ABANDON_END',
@@ -437,12 +439,7 @@
} ),
'ABANDON_* share the same token.'
);
-
- done();
} );
-
- // After ABANDON_END_DELAY milliseconds...
- this.waitDeferreds[ 0 ].resolve();
} );
QUnit.module( 'ext.popups/actions#saveSettings' );
--
To view, visit https://gerrit.wikimedia.org/r/348919
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1acdfc15237d1d91e144b9fa5933ab6b3cfd9186
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Popups
Gerrit-Branch: master
Gerrit-Owner: Phuedx <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
