Sbisson has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/348937 )

Change subject: Synchronize rc_patrolled despite $wgUseRCPatrol
......................................................................

Synchronize rc_patrolled despite $wgUseRCPatrol

Always update rc_patrolled when revisions are
approved and unapproved. This allows ORES to
stop showing the "r" flag when changes have
approved.

Bug: T161888
Change-Id: I51983b7b910ab836a1913a73b2a1a2df8b754104
---
M business/RevisionReviewForm.php
1 file changed, 0 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/FlaggedRevs 
refs/changes/37/348937/1

diff --git a/business/RevisionReviewForm.php b/business/RevisionReviewForm.php
index d3e0058..84aab90 100644
--- a/business/RevisionReviewForm.php
+++ b/business/RevisionReviewForm.php
@@ -551,8 +551,6 @@
         * @return void
         */
        public static function updateRecentChanges( $rev, $patrol, $srev ) {
-               global $wgUseRCPatrol;
-
                if ( $rev instanceof RecentChange ) {
                        $pageId = $rev->mAttribs['rc_cur_id'];
                } else {
@@ -563,11 +561,6 @@
                $dbw = wfGetDB( DB_MASTER );
                $limit = 100; // sanity limit to avoid slave lag (most useful 
when FR is first enabled)
                $conds = [ 'rc_cur_id' => $pageId ];
-               if ( !$wgUseRCPatrol ) {
-                       # No sense in updating all the rows, only the new page 
one is used.
-                       # If $wgUseNPPatrol is off, then not even those are 
used.
-                       $conds['rc_type'] = RC_NEW; // reduce rows to UPDATE
-               }
 
                $newPatrolState = null; // set rc_patrolled to this value
                # If we accepted this rev, then mark prior revs as patrolled...

-- 
To view, visit https://gerrit.wikimedia.org/r/348937
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I51983b7b910ab836a1913a73b2a1a2df8b754104
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/FlaggedRevs
Gerrit-Branch: master
Gerrit-Owner: Sbisson <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to