jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/341592 )
Change subject: Form should not validate if manual errors are present
......................................................................
Form should not validate if manual errors are present
TODO: I'd like to understand when and why this changed, and why validation and
manual errors were treated differently.
Bug: T98447
Change-Id: I22d7ee350820db8a1fb37124a0690b0b3d397784
---
M gateway_common/GatewayPage.php
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
jenkins-bot: Verified
Ejegg: Looks good to me, approved
diff --git a/gateway_common/GatewayPage.php b/gateway_common/GatewayPage.php
index 7e53803..a220050 100644
--- a/gateway_common/GatewayPage.php
+++ b/gateway_common/GatewayPage.php
@@ -348,7 +348,7 @@
if ( $this->isProcessImmediate() ) {
// Check form for errors
// FIXME: Should this be rolled into
adapter.doPayment?
- $form_errors = $this->validateForm();
+ $form_errors = $this->validateForm() ||
$this->adapter->getManualErrors();
// If there were errors, redisplay form,
otherwise proceed to next step
if ( $form_errors ) {
--
To view, visit https://gerrit.wikimedia.org/r/341592
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I22d7ee350820db8a1fb37124a0690b0b3d397784
Gerrit-PatchSet: 8
Gerrit-Project: mediawiki/extensions/DonationInterface
Gerrit-Branch: master
Gerrit-Owner: Awight <awi...@wikimedia.org>
Gerrit-Reviewer: AndyRussG <andrew.green...@gmail.com>
Gerrit-Reviewer: Cdentinger <cdentin...@wikimedia.org>
Gerrit-Reviewer: Ejegg <eeggles...@wikimedia.org>
Gerrit-Reviewer: Ssmith <ssm...@wikimedia.org>
Gerrit-Reviewer: XenoRyet <dkozlow...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
