jenkins-bot has submitted this change and it was merged.
Change subject: mw.loader: Prevent useless jobs from being added to queue
......................................................................
mw.loader: Prevent useless jobs from being added to queue
* load was calling request with ready and error being null.
* request was doing a strict check against undefined to prevent adding
jobs with no callbacks to the queue.
* Since these were null rather than undefined, the empty jobs got added
anyway. Now using undefined instead.
* Mark ready and error as optional in the request JS documentation.
Change-Id: I6428e733899f7c484f842f6fe142c8d4d49ee443
---
M resources/mediawiki/mediawiki.js
1 file changed, 3 insertions(+), 3 deletions(-)
Approvals:
Krinkle: Looks good to me, approved
jenkins-bot: Verified
diff --git a/resources/mediawiki/mediawiki.js b/resources/mediawiki/mediawiki.js
index b5b42e1..1212fd4 100644
--- a/resources/mediawiki/mediawiki.js
+++ b/resources/mediawiki/mediawiki.js
@@ -970,8 +970,8 @@
*
* @private
* @param {string|string[]} dependencies Module name or
array of string module names
- * @param {Function} ready Callback to execute when all
dependencies are ready
- * @param {Function} error Callback to execute when any
dependency fails
+ * @param {Function} [ready] Callback to execute when
all dependencies are ready
+ * @param {Function} [error] Callback to execute when
any dependency fails
* @param {boolean} [async] If true, load modules
asynchronously even if
* document ready has not yet occurred.
*/
@@ -1447,7 +1447,7 @@
return;
}
// Since some modules are not yet
ready, queue up a request.
- request( filtered, null, null, async );
+ request( filtered, undefined,
undefined, async );
},
/**
--
To view, visit https://gerrit.wikimedia.org/r/51828
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6428e733899f7c484f842f6fe142c8d4d49ee443
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Mattflaschen <[email protected]>
Gerrit-Reviewer: Catrope <[email protected]>
Gerrit-Reviewer: Krinkle <[email protected]>
Gerrit-Reviewer: Ori.livneh <[email protected]>
Gerrit-Reviewer: Spage <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
