Dzahn has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/347984 )
Change subject: dnsrec/icinga: add child/parent rel between monitor hosts ...................................................................... dnsrec/icinga: add child/parent rel between monitor hosts dnsrec hosts exist in Icinga in 2 ways. First as regular hosts with default checks incl. ping and second there are "virtual hosts" added in with a monitoring::host in modules/dnsrecursor/manifests/monitor.pp which adds one host per IP address. This is for the "check_dns!www.wikipedia.org" check which is applied to BOTH the IPv4 and the IPv6 address of the host by: modules/role/manifests/dnsrecursor.pp: ::dnsrecursor::monitor { [ $::ipaddress, $::ipaddress6_eth0 ]: } Today we had a reinstall of one of these servers and even though the first kind of hosts were downtimed in Icinga we still did get alerts about those other virtual IP hosts not being reachable. This change should tell Icinga to consider these hosts as a child of their parent host. This should result in a status "UNREACHABLE" instead of "DOWN" because Icinga then understands it just can't get to them because the other host is down per its reachability logic. This in turn should mean that icinga-wm is not reporting it on IRC and spamming us because notification settings are to just report DOWN/UP/FLAP for hosts. (and if not we can adjust that) https://docs.icinga.com/latest/en/networkreachability.html#parentchildrelations Change-Id: I7ab92a15f51f038316fc5505ab0d737d93ee52d9 --- M modules/dnsrecursor/manifests/monitor.pp 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Alexandros Kosiaris: Looks good to me, but someone else must approve jenkins-bot: Verified Dzahn: Looks good to me, approved diff --git a/modules/dnsrecursor/manifests/monitor.pp b/modules/dnsrecursor/manifests/monitor.pp index c1e1cb7..e2e1b48 100644 --- a/modules/dnsrecursor/manifests/monitor.pp +++ b/modules/dnsrecursor/manifests/monitor.pp @@ -3,6 +3,7 @@ # Monitoring monitoring::host { $title: ip_address => $title, + parents => $::hostname, } monitoring::service { "recursive dns ${title}": host => $title, -- To view, visit https://gerrit.wikimedia.org/r/347984 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7ab92a15f51f038316fc5505ab0d737d93ee52d9 Gerrit-PatchSet: 5 Gerrit-Project: operations/puppet Gerrit-Branch: production Gerrit-Owner: Dzahn <dz...@wikimedia.org> Gerrit-Reviewer: Alexandros Kosiaris <akosia...@wikimedia.org> Gerrit-Reviewer: BBlack <bbl...@wikimedia.org> Gerrit-Reviewer: Dzahn <dz...@wikimedia.org> Gerrit-Reviewer: Giuseppe Lavagetto <glavage...@wikimedia.org> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits