Alexandros Kosiaris has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/349176 )

Change subject: puppet_compiler: Use dirname in the conftool namespace
......................................................................


puppet_compiler: Use dirname in the conftool namespace

Since we don't rely on hiera, which does a dirname on the looked up key,
we should try to imitate as much as possible. For now just use dirname
and reevaluate

Change-Id: I08800611828a4ebdb1629a431b5e61fecadd4d74
---
M modules/role/manifests/puppet_compiler.pp
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Alexandros Kosiaris: Verified; Looks good to me, approved



diff --git a/modules/role/manifests/puppet_compiler.pp 
b/modules/role/manifests/puppet_compiler.pp
index 736db4e..ad9aae8 100644
--- a/modules/role/manifests/puppet_compiler.pp
+++ b/modules/role/manifests/puppet_compiler.pp
@@ -25,7 +25,7 @@
         srv_domain => '',
         host       => '127.0.0.1',
         port       => 2379,
-        namespace  => '/conftool/v1',
+        namespace  => dirname('/conftool/v1'),
         protocol   => 'http',
     }
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/349176
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I08800611828a4ebdb1629a431b5e61fecadd4d74
Gerrit-PatchSet: 2
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Alexandros Kosiaris <akosia...@wikimedia.org>
Gerrit-Reviewer: Alexandros Kosiaris <akosia...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to