Kipcool has uploaded a new change for review.
https://gerrit.wikimedia.org/r/51880
Change subject: Arrow pointing the other side for rtl css resourceloader for
delete icon
......................................................................
Arrow pointing the other side for rtl
css resourceloader for delete icon
Change-Id: I005ed8da5d698973072b72c31d2c0af46f718a2a
---
M OmegaWiki/Editor.php
M OmegaWiki/resources/tables.css
2 files changed, 13 insertions(+), 4 deletions(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/WikiLexicalData
refs/changes/80/51880/1
diff --git a/OmegaWiki/Editor.php b/OmegaWiki/Editor.php
index c3d3732..c1ad351 100644
--- a/OmegaWiki/Editor.php
+++ b/OmegaWiki/Editor.php
@@ -301,15 +301,17 @@
}
// if it is collapsible, continue
+ global $wgLang;
+ $arrow = ( $wgLang->getDir() == 'ltr' ) ? "▶" : "◀" ;
$prefix = HTML::element('span', array(
'id' => "prefix-collapsed-$elementId" ,
'class' => "collapse-$class"
- ) , "▶" ) ;
+ ) , $arrow ) ;
$prefix .= HTML::element('span', array(
'id' => "prefix-expanded-$elementId" ,
'class' => "expand-$class"
) , "▼" ) ;
-
+
return $prefix ;
}
@@ -765,8 +767,11 @@
$headerRows = getStructureAsTableHeaderRows( $visibleStructure,
$columnOffset, $idPath );
$result .= Xml::openElement( 'thead' );
- if ( $this->allowRemove )
- $headerRows[0] = '<th class="remove" rowspan="' .
count( $headerRows ) . '"><img src="' . $wgScriptPath .
'/extensions/WikiLexicalData/Images/Delete.png" title="' . wfMsgSc(
"RemoveHint" ) . '" alt="' . wfMsgSc( "Remove" ) . '"/></th>' . $headerRows[0];
+ if ( $this->allowRemove ) {
+ $headerRows[0] = HTML::element( 'th',
+ array( 'class' => 'wld-remove-header',
'rowspan' => count( $headerRows ), 'title' => wfMsgSc( "RemoveHint" ) )
+ ).$headerRows[0];
+ }
if ( $this->repeatInput )
$headerRows[0] .= '<th class="add" rowspan="' . count(
$headerRows ) . '">Input rows</th>';
diff --git a/OmegaWiki/resources/tables.css b/OmegaWiki/resources/tables.css
index 3ce587d..0fdb358 100644
--- a/OmegaWiki/resources/tables.css
+++ b/OmegaWiki/resources/tables.css
@@ -97,6 +97,10 @@
width: auto;
}
+.wld-remove-header {
+ /* @embed */
+ background: url("../../Images/Delete.png") no-repeat center;
+}
.wd-languagecurrent {
font-size:large ;
--
To view, visit https://gerrit.wikimedia.org/r/51880
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I005ed8da5d698973072b72c31d2c0af46f718a2a
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikiLexicalData
Gerrit-Branch: master
Gerrit-Owner: Kipcool <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
