Sbisson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/349251 )
Change subject: MentionStatus: prefer failure-type
......................................................................
MentionStatus: prefer failure-type
In MentionStatusPresentationModel, prefer
extra['failure-type'] to event-type to determine
why the mention was not sent.
Bug: T144614
Change-Id: Id3b55e15a0c1a8f3fee19cbe07983c6e373b309e
---
M includes/formatters/MentionStatusPresentationModel.php
1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Echo
refs/changes/51/349251/1
diff --git a/includes/formatters/MentionStatusPresentationModel.php
b/includes/formatters/MentionStatusPresentationModel.php
index 5b9c808..b5417eb 100644
--- a/includes/formatters/MentionStatusPresentationModel.php
+++ b/includes/formatters/MentionStatusPresentationModel.php
@@ -120,7 +120,8 @@
}
private function isTooManyMentionsFailure() {
- return $this->getType() === 'mention-failure-too-many';
+ return $this->getFailureType() === 'too-many' ||
+ $this->getType() === 'mention-failure-too-many';
}
private function getMaxMentions() {
--
To view, visit https://gerrit.wikimedia.org/r/349251
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id3b55e15a0c1a8f3fee19cbe07983c6e373b309e
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Echo
Gerrit-Branch: master
Gerrit-Owner: Sbisson <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
