Aaron Schulz has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/349268 )
Change subject: Fix bogus variable use in RefreshLinksJob::run()
......................................................................
Fix bogus variable use in RefreshLinksJob::run()
Also removed two unused loop variables.
Change-Id: I9a9e0a83bdaa13c031857bc20f977161cf85baff
---
M includes/jobqueue/jobs/RefreshLinksJob.php
1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/68/349268/1
diff --git a/includes/jobqueue/jobs/RefreshLinksJob.php
b/includes/jobqueue/jobs/RefreshLinksJob.php
index 64d955a..02bb829 100644
--- a/includes/jobqueue/jobs/RefreshLinksJob.php
+++ b/includes/jobqueue/jobs/RefreshLinksJob.php
@@ -87,7 +87,7 @@
// When the base job branches, wait for the replica DBs
to catch up to the master.
// From then on, we know that any template changes at
the time the base job was
// enqueued will be reflected in backlink page parses
when the leaf jobs run.
- if ( !isset( $params['range'] ) ) {
+ if ( !isset( $this->params['range'] ) ) {
try {
$lbFactory =
MediaWikiServices::getInstance()->getDBLoadBalancerFactory();
$lbFactory->waitForReplication( [
@@ -113,7 +113,7 @@
JobQueueGroup::singleton()->push( $jobs );
// Job to update link tables for a set of titles
} elseif ( isset( $this->params['pages'] ) ) {
- foreach ( $this->params['pages'] as $pageId =>
$nsAndKey ) {
+ foreach ( $this->params['pages'] as $nsAndKey ) {
list( $ns, $dbKey ) = $nsAndKey;
$this->runForTitle( Title::makeTitleSafe( $ns,
$dbKey ) );
}
@@ -253,7 +253,7 @@
// This avoids snapshot-clearing errors in
LinksUpdate::acquirePageLock().
$lbFactory->commitAndWaitForReplication( __METHOD__, $ticket );
- foreach ( $updates as $key => $update ) {
+ foreach ( $updates as $update ) {
// FIXME: This code probably shouldn't be here?
// Needed by things like Echo notifications which need
// to know which user caused the links update
--
To view, visit https://gerrit.wikimedia.org/r/349268
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9a9e0a83bdaa13c031857bc20f977161cf85baff
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Aaron Schulz <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
