Jforrester has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/349279 )
Change subject: tests: Drop unnecessary hints to qunit about the number of tests
......................................................................
tests: Drop unnecessary hints to qunit about the number of tests
Change-Id: I621dc1a01d20d24411661c69f9c2b89a9d4df5a4
---
M tests/Element.test.js
M tests/Process.test.js
M tests/core.test.js
M tests/mixins/FlaggedElement.test.js
M tests/widgets/MenuTagMultiselectWidget.test.js
5 files changed, 19 insertions(+), 19 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/oojs/ui refs/changes/79/349279/1
diff --git a/tests/Element.test.js b/tests/Element.test.js
index 535aaf3..723781e 100644
--- a/tests/Element.test.js
+++ b/tests/Element.test.js
@@ -15,7 +15,7 @@
}
} );
-QUnit.test( 'static.infuse', 2, function ( assert ) {
+QUnit.test( 'static.infuse', function ( assert ) {
function infuse( data ) {
return OO.ui.Element.static.infuse(
$( '<div>' ).attr( 'data-ooui', JSON.stringify( data ) )
@@ -27,7 +27,7 @@
}, Error );
} );
-QUnit.test( 'static.getDocument', 10, function ( assert ) {
+QUnit.test( 'static.getDocument', function ( assert ) {
var frameDoc, frameEl, frameDiv,
el = this.fixture,
div = document.createElement( 'div' ),
@@ -55,7 +55,7 @@
assert.strictEqual( OO.ui.Element.static.getDocument( {} ), null,
'Invalid' );
} );
-QUnit.test( 'getElementDocument', 1, function ( assert ) {
+QUnit.test( 'getElementDocument', function ( assert ) {
var el, doc;
doc = document;
diff --git a/tests/Process.test.js b/tests/Process.test.js
index 00eef1a..13f3d40 100644
--- a/tests/Process.test.js
+++ b/tests/Process.test.js
@@ -2,7 +2,7 @@
/* Tests */
-QUnit.test( 'next', 1, function ( assert ) {
+QUnit.test( 'next', function ( assert ) {
var process = new OO.ui.Process(),
result = [];
@@ -22,7 +22,7 @@
} );
} );
-QUnit.test( 'first', 1, function ( assert ) {
+QUnit.test( 'first', function ( assert ) {
var process = new OO.ui.Process(),
result = [];
@@ -42,7 +42,7 @@
} );
} );
-QUnit.test( 'execute (async)', 1, function ( assert ) {
+QUnit.test( 'execute (async)', function ( assert ) {
var process = new OO.ui.Process(),
result = [];
@@ -80,7 +80,7 @@
} );
} );
-QUnit.test( 'execute (return false)', 1, function ( assert ) {
+QUnit.test( 'execute (return false)', function ( assert ) {
var process = new OO.ui.Process(),
result = [];
@@ -114,7 +114,7 @@
} );
} );
-QUnit.test( 'execute (async reject)', 1, function ( assert ) {
+QUnit.test( 'execute (async reject)', function ( assert ) {
var process = new OO.ui.Process(),
result = [];
@@ -147,7 +147,7 @@
} );
} );
-QUnit.test( 'execute (wait)', 1, function ( assert ) {
+QUnit.test( 'execute (wait)', function ( assert ) {
var process = new OO.ui.Process(),
result = [];
diff --git a/tests/core.test.js b/tests/core.test.js
index 83e521f..8624a72 100644
--- a/tests/core.test.js
+++ b/tests/core.test.js
@@ -3,7 +3,7 @@
/**
* @note: Keep tests in sync with phpunit/TagTest.php
*/
-QUnit.test( 'isSafeUrl', 13, function ( assert ) {
+QUnit.test( 'isSafeUrl', function ( assert ) {
// eslint-disable-next-line no-script-url
assert.notOk( OO.ui.isSafeUrl( 'javascript:evil();' ) );
assert.notOk( OO.ui.isSafeUrl( 'foo:bar' ) );
@@ -20,7 +20,7 @@
assert.ok( OO.ui.isSafeUrl( '/wiki/Extra:Colon' ) );
} );
-QUnit.test( 'isFocusableElement', 10, function ( assert ) {
+QUnit.test( 'isFocusableElement', function ( assert ) {
var i, $html, result,
cases = [
{
@@ -94,7 +94,7 @@
}
} );
-QUnit.test( 'debounce', 4, function ( assert ) {
+QUnit.test( 'debounce', function ( assert ) {
var f,
log = [],
testTimer = new OO.ui.TestTimer(),
@@ -178,7 +178,7 @@
}
} );
-QUnit.test( 'throttle', 2, function ( assert ) {
+QUnit.test( 'throttle', function ( assert ) {
var f,
log = [],
testTimer = new OO.ui.TestTimer(),
diff --git a/tests/mixins/FlaggedElement.test.js
b/tests/mixins/FlaggedElement.test.js
index 464819a..c7e1b7c 100644
--- a/tests/mixins/FlaggedElement.test.js
+++ b/tests/mixins/FlaggedElement.test.js
@@ -8,7 +8,7 @@
OO.inheritClass( TestElement, OO.ui.Widget );
OO.mixinClass( TestElement, OO.ui.mixin.FlaggedElement );
- QUnit.test( 'constructor', 2, function ( assert ) {
+ QUnit.test( 'constructor', function ( assert ) {
var element;
element = new TestElement();
@@ -20,7 +20,7 @@
assert.deepEqual( element.getFlags(), [ 'foo' ], 'Config option
"flags"' );
} );
- QUnit.test( 'getFlags', 2, function ( assert ) {
+ QUnit.test( 'getFlags', function ( assert ) {
var element = new TestElement();
element.setFlags( 'foo' );
@@ -30,7 +30,7 @@
assert.deepEqual( element.getFlags(), [], 'Flag was removed' );
} );
- QUnit.test( 'hasFlag', 3, function ( assert ) {
+ QUnit.test( 'hasFlag', function ( assert ) {
var element = new TestElement();
assert.deepEqual( element.hasFlag( 'foo' ), false, 'Flag absent
by default' );
@@ -41,14 +41,14 @@
assert.deepEqual( element.hasFlag( 'foo' ), false, 'Flag was
removed' );
} );
- QUnit.test( 'clearFlags', 1, function ( assert ) {
+ QUnit.test( 'clearFlags', function ( assert ) {
var element = new TestElement();
element.setFlags( 'foo' );
element.clearFlags();
assert.deepEqual( element.hasFlag( 'foo' ), false, 'Flag was
removed' );
} );
- QUnit.test( 'setFlags', 5, function ( assert ) {
+ QUnit.test( 'setFlags', function ( assert ) {
var element = new TestElement();
element.setFlags( 'foo' );
assert.deepEqual( element.hasFlag( 'foo' ), true, 'string' );
diff --git a/tests/widgets/MenuTagMultiselectWidget.test.js
b/tests/widgets/MenuTagMultiselectWidget.test.js
index 639cda9..5ca904f 100644
--- a/tests/widgets/MenuTagMultiselectWidget.test.js
+++ b/tests/widgets/MenuTagMultiselectWidget.test.js
@@ -1,7 +1,7 @@
( function () {
QUnit.module( 'MenuTagMultiselectWidget' );
- QUnit.test( 'isAllowedData', 4, function ( assert ) {
+ QUnit.test( 'isAllowedData', function ( assert ) {
var widget;
widget = new OO.ui.MenuTagMultiselectWidget( {
--
To view, visit https://gerrit.wikimedia.org/r/349279
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I621dc1a01d20d24411661c69f9c2b89a9d4df5a4
Gerrit-PatchSet: 1
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: Jforrester <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
