Brian Wolff has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/349282 )

Change subject: Enforce MW coding convention with phpcs
......................................................................

Enforce MW coding convention with phpcs

(This commit will probably fail unit tests, but it will
tell you all the things that need doing before enforcing tests)

Bug: T163487
Change-Id: Ibd2aeddd1e71122f006173c562b446685d7e9127
---
M composer.json
A phpcs.xml
2 files changed, 18 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Newsletter 
refs/changes/82/349282/1

diff --git a/composer.json b/composer.json
index 1c46fe6..756816e 100644
--- a/composer.json
+++ b/composer.json
@@ -4,11 +4,14 @@
                "wikimedia/assert": ">=0.1 <0.3"
        },
        "require-dev": {
-               "jakub-onderka/php-parallel-lint": "0.9.2"
+               "jakub-onderka/php-parallel-lint": "0.9.2",
+               "mediawiki/mediawiki-codesniffer": "0.7.2"
        },
        "scripts": {
                "test": [
-                       "parallel-lint . --exclude vendor"
-               ]
+                       "parallel-lint . --exclude vendor",
+                       "phpcs -p -s"
+               ],
+               "fix": "phpcbf"
        }
 }
diff --git a/phpcs.xml b/phpcs.xml
new file mode 100644
index 0000000..63c9297
--- /dev/null
+++ b/phpcs.xml
@@ -0,0 +1,12 @@
+<?xml version="1.0"?>
+<ruleset>
+       <rule ref="vendor/mediawiki/mediawiki-codesniffer/MediaWiki"/>
+       <rule ref="Generic.Files.LineLength.TooLong">
+               <exclude-pattern>*/tests/*</exclude-pattern>
+       </rule>
+       <file>.</file>
+       <arg name="extensions" value="php,php5,inc"/>
+       <arg name="encoding" value="utf8"/>
+       <exclude-pattern>node_modules</exclude-pattern>
+       <exclude-pattern>vendor</exclude-pattern>
+</ruleset>

-- 
To view, visit https://gerrit.wikimedia.org/r/349282
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibd2aeddd1e71122f006173c562b446685d7e9127
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Newsletter
Gerrit-Branch: master
Gerrit-Owner: Brian Wolff <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to