[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: ve.init.mw.ArticleTarget: Use a simpler error message when s...

[Code Review]

Bartosz Dziewoński has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/349340 )

Change subject: ve.init.mw.ArticleTarget: Use a simpler error message when site 
is read-only
......................................................................

ve.init.mw.ArticleTarget: Use a simpler error message when site is read-only

Sites like to customize 'readonlywarning' with things that we can't parse.
Instead, use 'apierror-readonly'. The old message is still shown in edit
notices.

Bug: T163455
Change-Id: I592accde17b256ecee27820df12d9d312499f8f7
---
M extension.json
M modules/ve-mw/init/ve.init.mw.ArticleTarget.js
2 files changed, 4 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor 
refs/changes/40/349340/1

diff --git a/extension.json b/extension.json
index 90f9d1f..36b3a89 100644
--- a/extension.json
+++ b/extension.json
@@ -389,7 +389,7 @@
                                "editing",
                                "lastmodifiedat",
                                "parentheses",
-                               "readonlywarning",
+                               "apierror-readonly",
                                "redirectpagesub",
                                "subject",
                                "visualeditor-loadwarning",
diff --git a/modules/ve-mw/init/ve.init.mw.ArticleTarget.js 
b/modules/ve-mw/init/ve.init.mw.ArticleTarget.js
index 52204f4..597a136 100644
--- a/modules/ve-mw/init/ve.init.mw.ArticleTarget.js
+++ b/modules/ve-mw/init/ve.init.mw.ArticleTarget.js
@@ -614,7 +614,7 @@
                this.saveErrorHookAborted();
                return;
        } else if ( data.error && data.error.code === 'readonly' ) {
-               this.saveErrorReadOnly( data.error.readonlyreason );
+               this.saveErrorReadOnly();
                return;
        }
 
@@ -912,11 +912,10 @@
  * Handle read only error
  *
  * @method
- * @param {string} reason The reason given by the system administrator.
  * @fires saveErrorReadOnly
  */
-ve.init.mw.ArticleTarget.prototype.saveErrorReadOnly = function ( reason ) {
-       this.showSaveError( $( $.parseHTML( mw.message( 'readonlywarning', 
reason ).parse() ) ), true, true );
+ve.init.mw.ArticleTarget.prototype.saveErrorReadOnly = function () {
+       this.showSaveError( $( $.parseHTML( mw.message( 'apierror-readonly' 
).parse() ) ), true, true );
        this.emit( 'saveErrorReadOnly' );
 };
 

-- 
To view, visit https://gerrit.wikimedia.org/r/349340
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I592accde17b256ecee27820df12d9d312499f8f7
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński <matma....@gmail.com>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits