jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/342977 )
Change subject: Set default to 1 recent contributor instead of -1
......................................................................
Set default to 1 recent contributor instead of -1
Bug: T56888
Change-Id: I06bd0e5959d1ff561d71163bd5ce26f28f73981c
---
M maintenance/mssql/tables.sql
M maintenance/oracle/tables.sql
M maintenance/postgres/tables.sql
M maintenance/tables.sql
M tests/phpunit/includes/db/DatabaseSqliteTest.php
5 files changed, 5 insertions(+), 4 deletions(-)
Approvals:
Bartosz Dziewoński: Looks good to me, approved
jenkins-bot: Verified
diff --git a/maintenance/mssql/tables.sql b/maintenance/mssql/tables.sql
index 3babb39..41a2ef9 100644
--- a/maintenance/mssql/tables.sql
+++ b/maintenance/mssql/tables.sql
@@ -469,7 +469,7 @@
ss_users bigint default '-1',
-- Number of users that still edit
- ss_active_users bigint default '-1',
+ ss_active_users bigint default '1',
-- Number of images, equivalent to SELECT COUNT(*) FROM image
ss_images int default 0
diff --git a/maintenance/oracle/tables.sql b/maintenance/oracle/tables.sql
index fc3c696..fefc31c 100644
--- a/maintenance/oracle/tables.sql
+++ b/maintenance/oracle/tables.sql
@@ -255,7 +255,7 @@
ss_good_articles NUMBER DEFAULT 0,
ss_total_pages NUMBER DEFAULT -1,
ss_users NUMBER DEFAULT -1,
- ss_active_users NUMBER DEFAULT -1,
+ ss_active_users NUMBER DEFAULT 1,
ss_images NUMBER DEFAULT 0
);
CREATE UNIQUE INDEX &mw_prefix.site_stats_u01 ON &mw_prefix.site_stats
(ss_row_id);
diff --git a/maintenance/postgres/tables.sql b/maintenance/postgres/tables.sql
index e19c447..9ded079 100644
--- a/maintenance/postgres/tables.sql
+++ b/maintenance/postgres/tables.sql
@@ -283,7 +283,7 @@
ss_good_articles INTEGER DEFAULT 0,
ss_total_pages INTEGER DEFAULT -1,
ss_users INTEGER DEFAULT -1,
- ss_active_users INTEGER DEFAULT -1,
+ ss_active_users INTEGER DEFAULT 1,
ss_admins INTEGER DEFAULT -1,
ss_images INTEGER DEFAULT 0
);
diff --git a/maintenance/tables.sql b/maintenance/tables.sql
index 8f59690..38fef45 100644
--- a/maintenance/tables.sql
+++ b/maintenance/tables.sql
@@ -758,7 +758,7 @@
ss_users bigint default '-1',
-- Number of users that still edit
- ss_active_users bigint default '-1',
+ ss_active_users bigint default '1',
-- Number of images, equivalent to SELECT COUNT(*) FROM image
ss_images int default 0
diff --git a/tests/phpunit/includes/db/DatabaseSqliteTest.php
b/tests/phpunit/includes/db/DatabaseSqliteTest.php
index 10bf028..d7fe022 100644
--- a/tests/phpunit/includes/db/DatabaseSqliteTest.php
+++ b/tests/phpunit/includes/db/DatabaseSqliteTest.php
@@ -309,6 +309,7 @@
// Mismatches for these columns we can safely ignore
$ignoredColumns = [
'user_newtalk.user_last_timestamp', // r84185
+ 'site_stats.ss_active_users', // T56888
];
$currentDB = DatabaseSqlite::newStandaloneInstance( ':memory:'
);
--
To view, visit https://gerrit.wikimedia.org/r/342977
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I06bd0e5959d1ff561d71163bd5ce26f28f73981c
Gerrit-PatchSet: 4
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: MZMcBride <[email protected]>
Gerrit-Reviewer: Bartosz Dziewoński <[email protected]>
Gerrit-Reviewer: Brian Wolff <[email protected]>
Gerrit-Reviewer: EddieGP <[email protected]>
Gerrit-Reviewer: Jjanes <[email protected]>
Gerrit-Reviewer: MZMcBride <[email protected]>
Gerrit-Reviewer: MaxSem <[email protected]>
Gerrit-Reviewer: Parent5446 <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
