jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/349403 )
Change subject: MentionInspector: Use surface fragment instead of building
transaction
......................................................................
MentionInspector: Use surface fragment instead of building transaction
Change-Id: Ie3b9fbec28c8f3cd861b39b0ae286dd22cd7334f
---
M
modules/editor/editors/visualeditor/ui/inspectors/mw.flow.ve.ui.MentionInspector.js
1 file changed, 1 insertion(+), 8 deletions(-)
Approvals:
Catrope: Looks good to me, approved
jenkins-bot: Verified
diff --git
a/modules/editor/editors/visualeditor/ui/inspectors/mw.flow.ve.ui.MentionInspector.js
b/modules/editor/editors/visualeditor/ui/inspectors/mw.flow.ve.ui.MentionInspector.js
index 1f87abb..562c073 100644
---
a/modules/editor/editors/visualeditor/ui/inspectors/mw.flow.ve.ui.MentionInspector.js
+++
b/modules/editor/editors/visualeditor/ui/inspectors/mw.flow.ve.ui.MentionInspector.js
@@ -229,14 +229,7 @@
return new OO.ui.Process( deferred.promise() );
} else if ( action === 'remove' ) {
return new OO.ui.Process( function () {
- var doc, nodeRange;
-
- doc = surfaceModel.getDocument();
- nodeRange = this.selectedNode.getOuterRange();
-
- surfaceModel.change(
- ve.dm.Transaction.newFromRemoval( doc,
nodeRange )
- );
+ this.getFragment().removeContent();
this.close( { action: action } );
}, this );
--
To view, visit https://gerrit.wikimedia.org/r/349403
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie3b9fbec28c8f3cd861b39b0ae286dd22cd7334f
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/Flow
Gerrit-Branch: master
Gerrit-Owner: Esanders <[email protected]>
Gerrit-Reviewer: Catrope <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
