jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/349494 )
Change subject: build: add grunt-contrib-jshint
......................................................................
build: add grunt-contrib-jshint
See T119973
Change-Id: I6f6284616e149287bbe8832ecd1a733e36b0979e
---
M Gruntfile.js
M package.json
2 files changed, 10 insertions(+), 1 deletion(-)
Approvals:
Gergő Tisza: Looks good to me, approved
jenkins-bot: Verified
diff --git a/Gruntfile.js b/Gruntfile.js
index 41961d8..83d7f94 100644
--- a/Gruntfile.js
+++ b/Gruntfile.js
@@ -9,10 +9,18 @@
var conf = grunt.file.readJSON( 'extension.json' );
grunt.loadNpmTasks( 'grunt-banana-checker' );
grunt.loadNpmTasks( 'grunt-jsonlint' );
+ grunt.loadNpmTasks( 'grunt-contrib-jshint' );
grunt.loadNpmTasks( 'grunt-stylelint' );
grunt.initConfig( {
banana: conf.MessagesDirs,
+ jshint: {
+ all: [
+ '**/*.js',
+ '!node_modules/**',
+ '!vendor/**'
+ ]
+ },
jsonlint: {
all: [
'**/*.json',
@@ -30,6 +38,6 @@
}
} );
- grunt.registerTask( 'test', [ 'jsonlint', 'banana', 'stylelint' ] );
+ grunt.registerTask( 'test', [ 'jsonlint', 'banana', 'jshint',
'stylelint' ] );
grunt.registerTask( 'default', 'test' );
};
diff --git a/package.json b/package.json
index d70d8e7..8dc2ebc 100644
--- a/package.json
+++ b/package.json
@@ -10,6 +10,7 @@
"devDependencies": {
"grunt": "1.0.1",
"grunt-banana-checker": "0.4.0",
+ "grunt-contrib-jshint": "1.1.0",
"grunt-jsonlint": "1.0.7",
"grunt-stylelint": "0.6.0",
"stylelint-config-wikimedia": "0.4.1",
--
To view, visit https://gerrit.wikimedia.org/r/349494
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6f6284616e149287bbe8832ecd1a733e36b0979e
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/JsonConfig
Gerrit-Branch: master
Gerrit-Owner: Hashar <[email protected]>
Gerrit-Reviewer: Gergő Tisza <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
