Daniel Werner has uploaded a new change for review.
https://gerrit.wikimedia.org/r/51958
Change subject: (bug 45674) when displaying Snak using deleted item, also mark
it as deleted
......................................................................
(bug 45674) when displaying Snak using deleted item, also mark it as deleted
Will not fully solve bug 45674 since there is still the issue with the link to
the current page.
Change-Id: I23f93435c500809e1e3b2ef1a2bf3535acfa5425
---
M lib/resources/Resources.php
M lib/resources/jquery.valueview.views/views.css
M lib/resources/jquery.valueview.views/wikibaseItem.js
3 files changed, 8 insertions(+), 8 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase
refs/changes/58/51958/1
diff --git a/lib/resources/Resources.php b/lib/resources/Resources.php
index 4fedcc8..811b824 100644
--- a/lib/resources/Resources.php
+++ b/lib/resources/Resources.php
@@ -602,6 +602,10 @@
'wikibase.parsers',
'jquery.eachchange',
),
+ 'messages' => array(
+ 'parentheses',
+ 'wikibase-entity-item',
+ )
),
);
diff --git a/lib/resources/jquery.valueview.views/views.css
b/lib/resources/jquery.valueview.views/views.css
index 9225222..c562162 100644
--- a/lib/resources/jquery.valueview.views/views.css
+++ b/lib/resources/jquery.valueview.views/views.css
@@ -8,8 +8,3 @@
* @license GNU GPL v2+
* @author Daniel Werner < daniel.wer...@wikimedia.de >
*/
-
-.valueview_wikibaseitem a span {
- color: #565656;
- font-style: italic;
-}
diff --git a/lib/resources/jquery.valueview.views/wikibaseItem.js
b/lib/resources/jquery.valueview.views/wikibaseItem.js
index 3bd4f26..c32f21d 100644
--- a/lib/resources/jquery.valueview.views/wikibaseItem.js
+++ b/lib/resources/jquery.valueview.views/wikibaseItem.js
@@ -154,14 +154,15 @@
fetchedItem = wb.fetchedEntities[ itemId ];
if( !fetchedItem ) {
- return itemId;
+ return wb.utilities.ui.buildMissingEntityInfo(
itemId, wb.Item );
}
var label = fetchedItem.getContent().getLabel();
if( !label ) {
- return $( document.createTextNode( itemId + ' '
) ).add(
- $( '<span/>' ).text( '(' + mw.msg(
'wikibase-label-empty' ) + ')' )
+ return $( document.createTextNode( itemId )
).add(
+ $( '<span/>', { 'class':
'wb-entity-undefinedinfo' } )
+ .text( ' ' + mw.msg(
'parentheses', mw.msg( 'wikibase-label-empty' ) ) )
);
}
--
To view, visit https://gerrit.wikimedia.org/r/51958
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I23f93435c500809e1e3b2ef1a2bf3535acfa5425
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Daniel Werner <daniel.wer...@wikimedia.de>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
