Hashar has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/349543 )

Change subject: build: add grunt-contrib-jshint
......................................................................

build: add grunt-contrib-jshint

See T119973

Change-Id: Ibfdfed62bdb41f4c9d33cb911f94c01d82a35100
---
M .jshintignore
M Gruntfile.js
M package.json
3 files changed, 9 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/PhpTagsMaps 
refs/changes/43/349543/1

diff --git a/.jshintignore b/.jshintignore
index 4f25103..af00c7f 100644
--- a/.jshintignore
+++ b/.jshintignore
@@ -1,2 +1,4 @@
+node_modules
+vendor
 # upstream libs
-services/Leaflet/leaflet/leaflet.js
\ No newline at end of file
+services/Leaflet/leaflet/leaflet.js
diff --git a/Gruntfile.js b/Gruntfile.js
index a45071e..7e41cd3 100644
--- a/Gruntfile.js
+++ b/Gruntfile.js
@@ -1,11 +1,15 @@
 /*jshint node:true */
 module.exports = function ( grunt ) {
        grunt.loadNpmTasks( 'grunt-jsonlint' );
+       grunt.loadNpmTasks( 'grunt-contrib-jshint' );
        grunt.loadNpmTasks( 'grunt-banana-checker' );
 
        grunt.initConfig( {
                banana: {
                        all: 'i18n/'
+               },
+               jshint: {
+                       all: '.'
                },
                jsonlint: {
                        all: [
@@ -16,6 +20,6 @@
                }
        } );
 
-       grunt.registerTask( 'test', [ 'jsonlint', 'banana' ] );
+       grunt.registerTask( 'test', [ 'jsonlint', 'banana', 'jshint' ] );
        grunt.registerTask( 'default', 'test' );
 };
diff --git a/package.json b/package.json
index bcf5b13..e87548c 100644
--- a/package.json
+++ b/package.json
@@ -6,6 +6,7 @@
        "devDependencies": {
                "grunt": "1.0.1",
                "grunt-banana-checker": "0.5.0",
+               "grunt-contrib-jshint": "1.1.0",
                "grunt-jsonlint": "1.1.0"
        }
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/349543
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibfdfed62bdb41f4c9d33cb911f94c01d82a35100
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/PhpTagsMaps
Gerrit-Branch: master
Gerrit-Owner: Hashar <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to