Ladsgroup has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/349867 )
Change subject: [WIP] [Code experiment] Try to select all columns from wb_terms
......................................................................
[WIP] [Code experiment] Try to select all columns from wb_terms
Bug: T123867
Change-Id: I169302dc38c5a5e1d20aea1ab3bc891b744b3b51
---
M lib/includes/Store/Sql/SqlEntityInfoBuilder.php
M lib/includes/Store/Sql/TermSqlIndex.php
2 files changed, 4 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase
refs/changes/67/349867/1
diff --git a/lib/includes/Store/Sql/SqlEntityInfoBuilder.php
b/lib/includes/Store/Sql/SqlEntityInfoBuilder.php
index a6c3103..ebb18c6 100644
--- a/lib/includes/Store/Sql/SqlEntityInfoBuilder.php
+++ b/lib/includes/Store/Sql/SqlEntityInfoBuilder.php
@@ -389,10 +389,11 @@
$dbw = $this->getConnection( DB_REPLICA );
// Do one query per term type here, this is way faster on
MySQL: T147748
+ // Select all columns for b/c T162673
foreach ( $termTypes as $termType ) {
$res = $dbw->select(
$this->termTable,
- array( 'term_entity_type', 'term_entity_id',
'term_type', 'term_language', 'term_text' ),
+ '*',
array_merge( $where, $termType !== null ? [
'term_type' => $termType ] : [] ),
__METHOD__
);
diff --git a/lib/includes/Store/Sql/TermSqlIndex.php
b/lib/includes/Store/Sql/TermSqlIndex.php
index 10ac82e..be5dca1 100644
--- a/lib/includes/Store/Sql/TermSqlIndex.php
+++ b/lib/includes/Store/Sql/TermSqlIndex.php
@@ -523,9 +523,10 @@
$dbr = $this->getReadDb();
+ // Select all columns T162673
$res = $dbr->select(
$this->tableName,
- [ 'term_entity_type', 'term_type', 'term_language',
'term_text', 'term_entity_id' ],
+ '*',
$conditions,
__METHOD__
);
--
To view, visit https://gerrit.wikimedia.org/r/349867
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I169302dc38c5a5e1d20aea1ab3bc891b744b3b51
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Ladsgroup <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
