Filippo Giunchedi has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/349925 )

Change subject: graphite: don't fire alarms on carbon-related spikes
......................................................................

graphite: don't fire alarms on carbon-related spikes

As seen during the switchover, a single spike for one of these metrics causes a
spurious alert to fire. Consider instead 80% of the retrieve data for alerting
purposes.

Change-Id: I33f3311a388bae025ff9a76ba323a486fcf8e8b0
---
M modules/graphite/manifests/monitoring/graphite.pp
1 file changed, 5 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/25/349925/1

diff --git a/modules/graphite/manifests/monitoring/graphite.pp 
b/modules/graphite/manifests/monitoring/graphite.pp
index 8ec2e4c..317f0f9 100644
--- a/modules/graphite/manifests/monitoring/graphite.pp
+++ b/modules/graphite/manifests/monitoring/graphite.pp
@@ -13,6 +13,7 @@
         from            => '5minutes',
         warning         => 25,
         critical        => 100,
+        percentage      => 80,
         nagios_critical => false,
     }
 
@@ -22,6 +23,7 @@
         from            => '5minutes',
         warning         => 25,
         critical        => 100,
+        percentage      => 80,
         nagios_critical => false,
     }
 
@@ -32,6 +34,7 @@
         from            => '10minutes',
         warning         => 1,
         critical        => 8,
+        percentage      => 80,
         nagios_critical => false,
     }
 
@@ -42,6 +45,7 @@
         from            => '10minutes',
         warning         => 1,
         critical        => 8,
+        percentage      => 80,
         nagios_critical => false,
     }
 
@@ -52,6 +56,7 @@
         from            => '1hour',
         warning         => 500,
         critical        => 1000,
+        percentage      => 80,
         nagios_critical => false,
     }
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/349925
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I33f3311a388bae025ff9a76ba323a486fcf8e8b0
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Filippo Giunchedi <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to