jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/349410 )
Change subject: Don't show preview if user has abandoned link ...................................................................... Don't show preview if user has abandoned link If the user dwells on a link for long enough, then the gateway makes a request, which is allowed to complete regardless of whether or not the response is required. If the user abandons the link but the request completes before the abandon completes - currently, ABANDON_END_DELAY is 300 ms - then the preview will be rendered temporarily. Fix this by not rendering the preview if the user has started to abandon the link. Bug: T163350 Change-Id: I154dde4e3ccaed3d11cb023c85c44451fc0ad957 --- M resources/dist/index.js M resources/dist/index.js.map M src/reducers/preview.js M tests/node-qunit/reducers/preview.test.js 4 files changed, 30 insertions(+), 7 deletions(-) Approvals: jenkins-bot: Verified Jdlrobson: Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/349410 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I154dde4e3ccaed3d11cb023c85c44451fc0ad957 Gerrit-PatchSet: 4 Gerrit-Project: mediawiki/extensions/Popups Gerrit-Branch: master Gerrit-Owner: Phuedx <[email protected]> Gerrit-Reviewer: Bmansurov <[email protected]> Gerrit-Reviewer: Jdlrobson <[email protected]> Gerrit-Reviewer: Phuedx <[email protected]> Gerrit-Reviewer: Pmiazga <[email protected]> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
