20after4 has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/350099 )
Change subject: Paper over "Notice: Undefined variable:
wmgRelatedArticlesFooterWhitelistedSkins"
......................................................................
Paper over "Notice: Undefined variable:
wmgRelatedArticlesFooterWhitelistedSkins"
Was caused by Ia1a6da9d844bd3ca7288a8d4f5f81a955e4061b4
Bug: T162941
Change-Id: I2f8ccdecbd1ec8332ff1bc539802a1f665efab73
---
M wmf-config/CommonSettings.php
1 file changed, 6 insertions(+), 3 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/operations/mediawiki-config
refs/changes/99/350099/1
diff --git a/wmf-config/CommonSettings.php b/wmf-config/CommonSettings.php
index a3b77fb..e0ccf18 100644
--- a/wmf-config/CommonSettings.php
+++ b/wmf-config/CommonSettings.php
@@ -2874,9 +2874,12 @@
if ( $wmgUseRelatedArticles ) {
wfLoadExtension( 'RelatedArticles' );
$wgRelatedArticlesShowInSidebar = $wmgRelatedArticlesShowInSidebar;
- // We need to override this.. not merge it.
- $wgRelatedArticlesFooterWhitelistedSkins =
$wmgRelatedArticlesFooterWhitelistedSkins;
-
+ // for unknown reasons, this isn't always set? This was causing this
error:
+ // "Notice: Undefined variable:
wmgRelatedArticlesFooterWhitelistedSkins"
+ if ( isset( $wmgRelatedArticlesFooterWhitelistedSkins ) ) {
+ // We need to override this.. not merge it.
+ $wgRelatedArticlesFooterWhitelistedSkins =
$wmgRelatedArticlesFooterWhitelistedSkins;
+ }
if ( $wmgRelatedArticlesShowInFooter ) {
wfLoadExtension( 'Cards' );
$wgRelatedArticlesShowInSidebar = false;
--
To view, visit https://gerrit.wikimedia.org/r/350099
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2f8ccdecbd1ec8332ff1bc539802a1f665efab73
Gerrit-PatchSet: 1
Gerrit-Project: operations/mediawiki-config
Gerrit-Branch: master
Gerrit-Owner: 20after4 <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
