jenkins-bot has submitted this change and it was merged.
Change subject: Remove unused local variable and use correct variables.
......................................................................
Remove unused local variable and use correct variables.
Change-Id: I510e1734f4f6624116520d006d8f8d1ef3d22f08
---
M melange/BundleCreater.php
1 file changed, 2 insertions(+), 3 deletions(-)
Approvals:
Nikerabbit: Looks good to me, approved
jenkins-bot: Verified
diff --git a/melange/BundleCreater.php b/melange/BundleCreater.php
index d529b1b..7297ec9 100644
--- a/melange/BundleCreater.php
+++ b/melange/BundleCreater.php
@@ -197,7 +197,7 @@
chdir( "{$this->dir}/extensions/$ext" );
$cBranch = escapeshellarg( $branch );
$cCheckout = escapeshellarg( $checkout );
- exec( "git checkout -b $branch $cCheckout --force
--quiet" );
+ exec( "git checkout -b $cBranch $cCheckout --force
--quiet" );
exec( "git reset --hard $cCheckout --quiet" );
exec( "git rm .gitreview --quiet --ignore-unmatch" );
@@ -226,7 +226,7 @@
exec( "git commit -v -m $msg --quiet" );
$cTag = escapeshellarg( $tag );
- exec( "git tag -a $tag -m $msg" );
+ exec( "git tag -a $cTag -m $msg" );
}
}
@@ -264,7 +264,6 @@
$tarname = escapeshellarg( "releases/$filename" );
$hashname = escapeshellarg( "$filename.$hasher" );
- $hashcommand = escapeshellarg( $hasher );
$cPiggyfile = escapeshellarg( $piggyfile );
exec( "tar cjf $tarname --exclude-vcs extensions $cPiggyfile" );
chdir( 'releases' );
--
To view, visit https://gerrit.wikimedia.org/r/51987
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I510e1734f4f6624116520d006d8f8d1ef3d22f08
Gerrit-PatchSet: 2
Gerrit-Project: translatewiki
Gerrit-Branch: master
Gerrit-Owner: Siebrand <[email protected]>
Gerrit-Reviewer: Nikerabbit <[email protected]>
Gerrit-Reviewer: Siebrand <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
