Gehel has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/350252 )

Change subject: change dependency from runtime to test on tools -> 
blazegraph-service
......................................................................

change dependency from runtime to test on tools -> blazegraph-service

The WAR is only used for testing and declaring it as runtime will include it
in the jar-with-dependencies, which is nto what we want!

Change-Id: I29d556ac90f7b8ebfdea7c382f12fe23701eb9bf
---
M tools/pom.xml
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/wikidata/query/rdf 
refs/changes/52/350252/1

diff --git a/tools/pom.xml b/tools/pom.xml
index 1c061c9..179e2c7 100644
--- a/tools/pom.xml
+++ b/tools/pom.xml
@@ -117,7 +117,7 @@
     </dependency>
     <dependency>
       <!--
-        adding a runtime dependency to blazegraph service to ensure that the
+        adding a test dependency to blazegraph service to ensure that the
         reactor build order is coherent. There should be a better way to do
         this, via an explicit dependency on the jetty-maven-plugin, but I can't
         find the correct syntax at the moment.
@@ -125,7 +125,7 @@
       <groupId>org.wikidata.query.rdf</groupId>
       <artifactId>blazegraph-service</artifactId>
       <type>war</type>
-      <scope>runtime</scope>
+      <scope>test</scope>
     </dependency>
     <dependency>
       <groupId>org.hamcrest</groupId>

-- 
To view, visit https://gerrit.wikimedia.org/r/350252
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I29d556ac90f7b8ebfdea7c382f12fe23701eb9bf
Gerrit-PatchSet: 1
Gerrit-Project: wikidata/query/rdf
Gerrit-Branch: master
Gerrit-Owner: Gehel <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to