Hello jenkins-bot,
I'd like you to do a code review. Please visit
https://gerrit.wikimedia.org/r/350388
to review the following change.
Change subject: Revert "Throw InvalidArgumentException in makeKnownLink on null"
......................................................................
Revert "Throw InvalidArgumentException in makeKnownLink on null"
Debugging done.
This reverts commit f945634705ab47d1518827c851c3ddb78f4eaf4f.
Change-Id: I7e7b7b8fd404a5a989fd4a8c22eec44df67c7587
---
M includes/linker/LinkRenderer.php
1 file changed, 1 insertion(+), 7 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/88/350388/1
diff --git a/includes/linker/LinkRenderer.php b/includes/linker/LinkRenderer.php
index 83fdede..c203a16 100644
--- a/includes/linker/LinkRenderer.php
+++ b/includes/linker/LinkRenderer.php
@@ -25,7 +25,6 @@
use Hooks;
use Html;
use HtmlArmor;
-use InvalidArgumentException;
use LinkCache;
use Linker;
use MediaWiki\MediaWikiServices;
@@ -281,13 +280,8 @@
* @return string
*/
public function makeKnownLink(
- $target, $text = null, array $extraAttribs = [], array $query =
[]
+ LinkTarget $target, $text = null, array $extraAttribs = [],
array $query = []
) {
- if ( $target instanceof LinkTarget ) {
- throw new InvalidArgumentException(
- 'Argument 1 passed to ' . __METHOD__ . ' must
implement ' . LinkTarget::class
- );
- }
$classes = [];
if ( $target->isExternal() ) {
$classes[] = 'extiw';
--
To view, visit https://gerrit.wikimedia.org/r/350388
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7e7b7b8fd404a5a989fd4a8c22eec44df67c7587
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: wmf/1.29.0-wmf.20
Gerrit-Owner: Addshore <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
