Tim Starling has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/350793 )
Change subject: EtcdConfig: use array_key_exists(), the value can be null
......................................................................
EtcdConfig: use array_key_exists(), the value can be null
Change-Id: Iae175401da8d49f5475d8c88cc5390b16e7cba32
---
M includes/config/EtcdConfig.php
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/93/350793/1
diff --git a/includes/config/EtcdConfig.php b/includes/config/EtcdConfig.php
index d3fbd65..06d8dfb 100644
--- a/includes/config/EtcdConfig.php
+++ b/includes/config/EtcdConfig.php
@@ -251,7 +251,7 @@
$name = basename( $node['key'] );
$value = $this->unserialize( $node['value'] );
- if ( !is_array( $value ) || !isset( $value['val'] ) ) {
+ if ( !is_array( $value ) || !array_key_exists( 'val',
$value ) ) {
return [ null, "Failed to parse value for
'$name'.", false ];
}
--
To view, visit https://gerrit.wikimedia.org/r/350793
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iae175401da8d49f5475d8c88cc5390b16e7cba32
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Tim Starling <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
