Lucas Werkmeister (WMDE) has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/350802 )
Change subject: Add margin-inline-start to complement margin-left ...................................................................... Add margin-inline-start to complement margin-left margin-left is incorrect in right-to-left languages, where we need the margin on the right side. Ideally, we’d replace it with margin-inline-start, which does what we need in all directions, but since that property is only supported in Firefox according to MDN [1], we keep margin-left as well. (In Firefox, having both margin-left and margin-inline-start doesn’t hurt – they’re not additive if they both refer to the same margin.) [1]: https://developer.mozilla.org/en-US/docs/Web/CSS/margin-inline-start#Browser_compatibility Change-Id: Ia1700a31030001152f5672f34a0cc5ed6a7ea957 --- M docs/user.js 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/WikibaseQualityConstraints refs/changes/02/350802/1 diff --git a/docs/user.js b/docs/user.js index 3e87048..304aaa9 100644 --- a/docs/user.js +++ b/docs/user.js @@ -19,6 +19,7 @@ } } ); widget.$element.css( 'margin-left', '0.5em' ); + widget.$element.css( 'margin-inline-start', '0.5em' ); widget.popup.$element.css( 'z-index', 2 ); // prevent collision with rank selector and property grey field; TODO better way to do this? return widget; } -- To view, visit https://gerrit.wikimedia.org/r/350802 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ia1700a31030001152f5672f34a0cc5ed6a7ea957 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/WikibaseQualityConstraints Gerrit-Branch: master Gerrit-Owner: Lucas Werkmeister (WMDE) <[email protected]> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
