jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/350533 )
Change subject: Add tests for lexemeformlistview
......................................................................
Add tests for lexemeformlistview
Change-Id: Ia6e0330f0523559ce906609a1f15d975f331902f
---
M src/WikibaseLexeme.hooks.php
A tests/qunit/jquery.wikibase.lexemeformlistview.tests.js
2 files changed, 63 insertions(+), 0 deletions(-)
Approvals:
WMDE-leszek: Looks good to me, approved
jenkins-bot: Verified
diff --git a/src/WikibaseLexeme.hooks.php b/src/WikibaseLexeme.hooks.php
index 3aae37a..5370b7a 100644
--- a/src/WikibaseLexeme.hooks.php
+++ b/src/WikibaseLexeme.hooks.php
@@ -84,6 +84,7 @@
'tests/qunit/special/formHelpers/LexemeLanguageFieldObserver.tests.js',
'tests/qunit/jquery.wikibase.lexemeformview.tests.js',
'tests/qunit/datamodel/LexemeForm.tests.js',
+
'tests/qunit/jquery.wikibase.lexemeformlistview.tests.js',
],
'dependencies' => [
'wikibase.lexeme.serialization.LexemeDeserializer',
@@ -93,6 +94,7 @@
'wikibase.lexeme.special.formHelpers.LexemeLanguageFieldObserver',
'wikibase.lexeme.datamodel.LexemeForm',
'jquery.wikibase.lexemeformview',
+ 'jquery.wikibase.lexemeformlistview',
'oojs-ui'
],
'localBasePath' => dirname( __DIR__ ),
diff --git a/tests/qunit/jquery.wikibase.lexemeformlistview.tests.js
b/tests/qunit/jquery.wikibase.lexemeformlistview.tests.js
new file mode 100644
index 0000000..a6e2255
--- /dev/null
+++ b/tests/qunit/jquery.wikibase.lexemeformlistview.tests.js
@@ -0,0 +1,61 @@
+/**
+ * @license GPL-2.0+
+ */
+( function( $, wb, QUnit, sinon ) {
+ 'use strict';
+
+ var lexemeformviewListItemAdapter = wb.tests.getMockListItemAdapter(
+ 'lexemeformview',
+ function() {
+ }
+ );
+
+ var createViewElement = function() {
+ var $node = $( '<div><div
class="wikibase-lexeme-forms"/></div>' );
+ return $node.lexemeformlistview( {
+ getListItemAdapter: function() {
+ return lexemeformviewListItemAdapter;
+ },
+ getAdder: function() {}
+ } );
+ };
+
+ var getViewFromElement = function( $view ) {
+ return $view.data( 'lexemeformlistview' );
+ };
+
+ var newView = function() {
+ return getViewFromElement( createViewElement() );
+ };
+
+ QUnit.module( 'jquery.wikibase.lexemeformlistview' );
+
+ QUnit.test( 'Can be created', function( assert ) {
+ var view = newView();
+
+ assert.ok( view instanceof $.wikibase.lexemeformlistview )
+ } );
+
+ QUnit.test( 'enterNewItem adds new list item', function( assert ) {
+ var view = newView(),
+ listItemAdapterSpy = sinon.spy(
lexemeformviewListItemAdapter, 'newListItem' );
+
+ assert.notOk( listItemAdapterSpy.called );
+
+ view.enterNewItem();
+
+ assert.ok( listItemAdapterSpy.called );
+ listItemAdapterSpy.restore();
+ } );
+
+ QUnit.test( 'Can be destroyed', function( assert ) {
+ var $view = createViewElement();
+
+ assert.ok( getViewFromElement( $view ) );
+
+ $view.data( 'lexemeformlistview' ).destroy();
+
+ assert.notOk( getViewFromElement( $view ) );
+ } );
+
+}( jQuery, wikibase, QUnit, sinon ) );
--
To view, visit https://gerrit.wikimedia.org/r/350533
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia6e0330f0523559ce906609a1f15d975f331902f
Gerrit-PatchSet: 8
Gerrit-Project: mediawiki/extensions/WikibaseLexeme
Gerrit-Branch: master
Gerrit-Owner: WMDE-leszek <[email protected]>
Gerrit-Reviewer: Aleksey Bekh-Ivanov (WMDE) <[email protected]>
Gerrit-Reviewer: Jakob <[email protected]>
Gerrit-Reviewer: Thiemo Mättig (WMDE) <[email protected]>
Gerrit-Reviewer: WMDE-leszek <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
