jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/350394 )
Change subject: Remove unused parameter from SpecialModifyEntity and subclasses
......................................................................
Remove unused parameter from SpecialModifyEntity and subclasses
Change-Id: I3ce9d6d9cfbf708b0be0843fbf74547fe9740c6e
---
M repo/includes/Specials/SpecialModifyEntity.php
M repo/includes/Specials/SpecialModifyTerm.php
M repo/includes/Specials/SpecialSetAliases.php
M repo/includes/Specials/SpecialSetDescription.php
M repo/includes/Specials/SpecialSetLabel.php
M repo/includes/Specials/SpecialSetLabelDescriptionAliases.php
M repo/includes/Specials/SpecialSetSiteLink.php
7 files changed, 1 insertion(+), 11 deletions(-)
Approvals:
jenkins-bot: Verified
Thiemo Mättig (WMDE): Looks good to me, approved
diff --git a/repo/includes/Specials/SpecialModifyEntity.php
b/repo/includes/Specials/SpecialModifyEntity.php
index 84252f6..bb998e8 100644
--- a/repo/includes/Specials/SpecialModifyEntity.php
+++ b/repo/includes/Specials/SpecialModifyEntity.php
@@ -43,7 +43,6 @@
/**
* @param string $title The title of the special page
- * @param string $restriction The required user right
* @param SpecialPageCopyrightView $copyrightView
* @param SummaryFormatter $summaryFormatter
* @param EntityRevisionLookup $entityRevisionLookup
@@ -52,7 +51,6 @@
*/
public function __construct(
$title,
- $restriction,
SpecialPageCopyrightView $copyrightView,
SummaryFormatter $summaryFormatter,
EntityRevisionLookup $entityRevisionLookup,
@@ -61,7 +59,7 @@
) {
parent::__construct(
$title,
- $restriction,
+ 'edit',
$copyrightView,
$summaryFormatter,
$entityTitleLookup,
diff --git a/repo/includes/Specials/SpecialModifyTerm.php
b/repo/includes/Specials/SpecialModifyTerm.php
index 54f1385..62b7349 100644
--- a/repo/includes/Specials/SpecialModifyTerm.php
+++ b/repo/includes/Specials/SpecialModifyTerm.php
@@ -53,7 +53,6 @@
/**
* @param string $title The title of the special page
- * @param string $restriction The required user right
* @param SpecialPageCopyrightView $copyrightView
* @param SummaryFormatter $summaryFormatter
* @param EntityRevisionLookup $entityRevisionLookup
@@ -62,7 +61,6 @@
*/
public function __construct(
$title,
- $restriction,
SpecialPageCopyrightView $copyrightView,
SummaryFormatter $summaryFormatter,
EntityRevisionLookup $entityRevisionLookup,
@@ -71,7 +69,6 @@
) {
parent::__construct(
$title,
- $restriction,
$copyrightView,
$summaryFormatter,
$entityRevisionLookup,
diff --git a/repo/includes/Specials/SpecialSetAliases.php
b/repo/includes/Specials/SpecialSetAliases.php
index e3f0129..5149a88 100644
--- a/repo/includes/Specials/SpecialSetAliases.php
+++ b/repo/includes/Specials/SpecialSetAliases.php
@@ -35,7 +35,6 @@
) {
parent::__construct(
'SetAliases',
- 'edit',
$copyrightView,
$summaryFormatter,
$entityRevisionLookup,
diff --git a/repo/includes/Specials/SpecialSetDescription.php
b/repo/includes/Specials/SpecialSetDescription.php
index 06be66c..5435aac 100644
--- a/repo/includes/Specials/SpecialSetDescription.php
+++ b/repo/includes/Specials/SpecialSetDescription.php
@@ -35,7 +35,6 @@
) {
parent::__construct(
'SetDescription',
- 'edit',
$copyrightView,
$summaryFormatter,
$entityRevisionLookup,
diff --git a/repo/includes/Specials/SpecialSetLabel.php
b/repo/includes/Specials/SpecialSetLabel.php
index 8e16d54..5cafa39 100644
--- a/repo/includes/Specials/SpecialSetLabel.php
+++ b/repo/includes/Specials/SpecialSetLabel.php
@@ -35,7 +35,6 @@
) {
parent::__construct(
'SetLabel',
- 'edit',
$copyrightView,
$summaryFormatter,
$entityRevisionLookup,
diff --git a/repo/includes/Specials/SpecialSetLabelDescriptionAliases.php
b/repo/includes/Specials/SpecialSetLabelDescriptionAliases.php
index 31f8cff..e2a6f25 100644
--- a/repo/includes/Specials/SpecialSetLabelDescriptionAliases.php
+++ b/repo/includes/Specials/SpecialSetLabelDescriptionAliases.php
@@ -80,7 +80,6 @@
) {
parent::__construct(
'SetLabelDescriptionAliases',
- 'edit',
$copyrightView,
$summaryFormatter,
$entityRevisionLookup,
diff --git a/repo/includes/Specials/SpecialSetSiteLink.php
b/repo/includes/Specials/SpecialSetSiteLink.php
index e7fa03e..d5e26d3 100644
--- a/repo/includes/Specials/SpecialSetSiteLink.php
+++ b/repo/includes/Specials/SpecialSetSiteLink.php
@@ -108,7 +108,6 @@
) {
parent::__construct(
'SetSiteLink',
- 'edit',
$copyrightView,
$summaryFormatter,
$entityRevisionLookup,
--
To view, visit https://gerrit.wikimedia.org/r/350394
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3ce9d6d9cfbf708b0be0843fbf74547fe9740c6e
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Thiemo Mättig (WMDE) <[email protected]>
Gerrit-Reviewer: Lucas Werkmeister (WMDE) <[email protected]>
Gerrit-Reviewer: Thiemo Mättig (WMDE) <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
